----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39797/#review104841 -----------------------------------------------------------
Ship it! LGTM! src/main/python/apache/aurora/client/cli/client.py (line 49) <https://reviews.apache.org/r/39797/#comment163106> Do you think it's worth adding a test case for this functionality? - Joshua Cohen On Nov. 3, 2015, 1:13 a.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39797/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 1:13 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1364 > https://issues.apache.org/jira/browse/AURORA-1364 > > > Repository: aurora > > > Description > ------- > > The only reasonable way to wire it in is via the AuthModule, which is the > only entity aware of the auth approach used. > > Also, dropped AuthModule.payload() as it's no longer needed (SessionKey > thrift struct is empty now). > > > Diffs > ----- > > src/main/python/apache/aurora/client/api/scheduler_client.py > 8ff21bf64c4a2e6678299439af42e9a0eeacbc7e > src/main/python/apache/aurora/client/cli/client.py > c17f857dd1fd6289e2b3ca8e3f86211ede1344ad > src/main/python/apache/aurora/common/auth/auth_module.py > e655cad8fbd3d23e3c44cbc38f6b6462d4781d9b > src/main/python/apache/aurora/common/auth/auth_module_manager.py > 2d785e7b274cb3be0b96322bc6b65a3c1ef5dfea > src/main/python/apache/aurora/kerberos/auth_module.py > fade00504a3122bc4b93e1cc1b7ebac6415303da > src/test/python/apache/aurora/client/api/test_scheduler_client.py > 1b4ff9cef167de1e4051e6aaa6e4fb6961fd20f1 > > Diff: https://reviews.apache.org/r/39797/diff/ > > > Testing > ------- > > ./pants test.pytest --no-fast src/test/python:: > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > Example error message: > ``` > ... > INFO] Instances to be killed: [0] > ERROR] INTERNAL: Communication with Aurora scheduler is kerberized. Did you > forget to run "kinit"? > 401 Client Error: Authorization Required > ``` > > > Thanks, > > Maxim Khutornenko > >
