-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40334/
-----------------------------------------------------------

(Updated Nov. 15, 2015, 4:32 p.m.)


Review request for Aurora, Joshua Cohen, Bill Farner, and Zameer Manji.


Changes
-------

Replace Twitter checkstyle with pants checkstyle.

This upgrades to pants 0.0.58 to pick up the newly split off pants
python checks contrib plugin.  Release notes are here:
  https://pypi.python.org/pypi/pantsbuild.pants/0.0.58

The plugin provides both python checkstyle (`compile.pythonstyle`), and
a python eval task (`compile.python-eval`).  The `python-eval` is turned
off since at least one of the Aurora python targets has files that have
side-effects upon import (a repl is started).

Now style checks run before compile (and thus before tests) and they
benefit from fingerprinting; ie: if you test your changes, those tests
will run style checks and when you go to commit, those checks will not
be re-run by the commit hook (although files you did not test will still
need to be checked).

A few production files were fixes up according to style failures coming
from no space after comment opening '#', unused variables, and
mis-aligned hanging closing parens.

 build-support/hooks/pre-commit                                        |  3 +--
 build-support/jenkins/build.sh                                        |  8 
++++----
 build-support/python/checkstyle                                       | 34 
----------------------------------
 build-support/python/checkstyle-check                                 |  6 
+++---
 pants.ini                                                             | 50 
++++++++++++++++++++++++++++++++++++++++++++++++++
 src/main/python/apache/aurora/admin/maintenance.py                    |  2 +-
 src/main/python/apache/aurora/client/api/__init__.py                  |  4 ++--
 src/main/python/apache/aurora/client/cli/client.py                    |  2 +-
 src/main/python/apache/aurora/client/cli/cron.py                      |  2 +-
 src/main/python/apache/thermos/core/process.py                        |  6 
+++---
 src/main/python/apache/thermos/monitoring/process_collector_psutil.py |  1 -
 src/test/python/apache/aurora/admin/test_admin.py                     |  6 
------
 src/test/python/apache/aurora/admin/util.py                           |  2 +-
 src/test/python/apache/aurora/client/cli/test_task.py                 |  3 +--
 14 files changed, 68 insertions(+), 61 deletions(-)


Repository: aurora


Description
-------

The problem is described here:
  https://github.com/pantsbuild/pants/issues/2566

Changelogs are here:
  https://pypi.python.org/pypi/pantsbuild.pants/0.0.59

 pants.ini | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Diffs (updated)
-----

  build-support/hooks/pre-commit 619fa9e245be49e4e1f21781c0908cbf744b10ea 
  build-support/jenkins/build.sh 41a392162f62236771ccbef5c9f94bf84b899f26 
  build-support/python/checkstyle 61acc22613acece01580761b25afc7a3edb6b845 
  build-support/python/checkstyle-check 
b2bfc5dd71193a8056828e9af05a4c16965f32a1 
  pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 
  src/main/python/apache/aurora/admin/maintenance.py 
6d94c923ae37bf6b827519d3505b100af306296b 
  src/main/python/apache/aurora/client/api/__init__.py 
6f07a3073a5d422373238619d459fbd09d8adf3d 
  src/main/python/apache/aurora/client/cli/client.py 
297fb588808c1eebc32ac3374265ba986dab3436 
  src/main/python/apache/aurora/client/cli/cron.py 
6376fd014f2a4da29442b5c2c7eb36578b503ba3 
  src/main/python/apache/thermos/core/process.py 
fe95cb3be01b47616596bd78cb9a919b2e8bd978 
  src/main/python/apache/thermos/monitoring/process_collector_psutil.py 
f1ec5a9050ac60700c4a8afa905bcf12a9bd8a44 
  src/test/python/apache/aurora/admin/test_admin.py 
8e204ab43c6bf69867ea7c32b0a7ba7fb29c0766 
  src/test/python/apache/aurora/admin/util.py 
3570407b51613d0a7b4fde8a4794d88b98e150b5 
  src/test/python/apache/aurora/client/cli/test_task.py 
5432a3d5f7e150b12bd75db0dac7a9018e1c6636 

Diff: https://reviews.apache.org/r/40334/diff/


Testing
-------

Before the fix stumbled into this:
```
$ ./build-support/jenkins/build.sh
...
11:22:51 00:00   [test]
11:22:51 00:00     [run_prep_command]
11:22:51 00:00     [test]
11:22:51 00:00     [pytest]
11:22:51 00:00       [run]

11:23:04 00:13         [chroot]
11:23:11 00:20   [complete]
               FAILURE

Exception message: Could not satisfy all requirements for pytest>=2.6,<2.7:
    pytest>=2.6,<2.7, pytest>=2.8.0(from: pytest-timeout)
```

That triggered a bit of a pants release firefight leading
to this RB and one for Medium's mono repo as well as patching
of the fix in at Square. Now
`./build-support/jenkins/build.sh` runs green as well.


Thanks,

John Sirois

Reply via email to