> On Nov. 15, 2015, 5:29 p.m., Bill Farner wrote:
> > build-support/thrift/Makefile, line 50
> > <https://reviews.apache.org/r/40323/diff/1/?file=1125752#file1125752line50>
> >
> >     On OS X 10.11 i get the following from this line:
> >     ```
> >     sha256=$(curl -s https://ftp.gnu.org/gnu/bison/bison-2.5.1.tar.gz | tee 
> > bison-2.5.1.tar.gz |    openssl sha256 | cut -d' ' -f2) && \
> >             [ "${sha256}" = 
> > "48dc3649231b75ac160d73528000ec89b6cd8d3b87cb7d0713f72ef4610442d4" ] && \
> >             tar zxvf bison-2.5.1.tar.gz && \
> >             cd bison-2.5.1 && \
> >             ./configure 
> > --prefix=/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install 
> > && \
> >                     make clean && make -j4 && \
> >             make install
> >     openssl:Error: 'sha256' is an invalid command.
> >     ```
> >     
> >     Looks like the command syntax on OS X is `openssl dgst -sha256`, i 
> > don't suppose that's supported by your version of openssl?
> >     
> >     I feel like i've been down this road before, not sure if  i've found a 
> > universal command.

`openssl dgst -sha256` does work for me.  I'll see if it works on my OSX 
10.10.5 machine and in the Vagrant image and report back.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40323/#review106577
-----------------------------------------------------------


On Nov. 14, 2015, 4:44 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40323/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2015, 4:44 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This improves the isolation of the thrift build by building a local
> pinned bison dep. For one, this gets thrift 0.9.1 building on Arch
> Linux, a rolling release that is otherwise too modern in its libs to
> successfully build thrift 0.9.1.
> 
> Additionally, this change knocks out the checksumming TODO and now
> checks all downloaded tarballs meet their expected hashes.  The
> hashes were generated locally after checking the sha1's where
> available.
> 
>  build-support/thrift/.gitignore |  7 ++++---
>  build-support/thrift/Makefile   | 47 
> ++++++++++++++++++++++++++++++++++++++---------
>  2 files changed, 42 insertions(+), 12 deletions(-)
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 
>   build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 
> 
> Diff: https://reviews.apache.org/r/40323/diff/
> 
> 
> Testing
> -------
> 
> I can now run `./build-support/jenkins/build.sh` green locally.
> 
> I also got a hold of an OSX 10.10.5 box and was able to run
> `./build-support/jenkins/build.sh` green on it using this change.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to