> On Nov. 15, 2015, 10:57 p.m., Bill Farner wrote: > > Heh, took a few rounds to understand what was going on > > here...case-insensitive file system strikes again! > > ``` > > ... > > Making install in lib > > /Library/Developer/CommandLineTools/usr/bin/make install-am > > if test no = no; then \ > > case 'darwin15.0.0' in \ > > darwin[56]*) \ > > need_charset_alias=true ;; \ > > darwin* | cygwin* | mingw* | pw32* | cegcc*) \ > > need_charset_alias=false ;; \ > > *) \ > > need_charset_alias=true ;; \ > > esac ; \ > > else \ > > need_charset_alias=false ; \ > > fi ; \ > > if $need_charset_alias; then \ > > /bin/sh > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/build-aux/install-sh > > -d /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib ; \ > > fi ; \ > > if test -f > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias; > > then \ > > sed -f ref-add.sed > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias > > > > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp > > ; \ > > /usr/bin/install -c -m 644 > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp > > > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias > > ; \ > > rm -f > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp > > ; \ > > else \ > > if $need_charset_alias; then \ > > sed -f ref-add.sed charset.alias > > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp > > ; \ > > /usr/bin/install -c -m 644 > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp > > > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.alias > > ; \ > > rm -f > > /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib/charset.tmp > > ; \ > > fi ; \ > > fi > > ../build-aux/install-sh -c -d > > '/Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install/lib' > > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: > > File exists > > mkdir: /Users/bill/code/aurora/build-support/thrift/bison-2.5.1/install: > > Not a directory > > make[5]: *** [install-libLIBRARIES] Error 1 > > make[4]: *** [install-am] Error 2 > > make[3]: *** [install] Error 2 > > make[2]: *** [install-recursive] Error 1 > > make[1]: *** [install] Error 2 > > ``` > > > > bison includes an INSTALL file, and your `--prefix` is `$dist/install` :-P > > John Sirois wrote: > Hrm - serves me right for installing OSX on case-sensitive HFS+. > Fixed; although the AuroraBot will continue to be red due to > https://reviews.apache.org/r/40334/
Alright - rebasing against https://reviews.apache.org/r/40334/ so AuroraBot can go green. - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106597 ----------------------------------------------------------- On Nov. 16, 2015, 8:13 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40323/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 8:13 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This improves the isolation of the thrift build by building a local > pinned bison dep. For one, this gets thrift 0.9.1 building on Arch > Linux, a rolling release that is otherwise too modern in its libs to > successfully build thrift 0.9.1. > > Additionally, this change knocks out the checksumming TODO and now > checks all downloaded tarballs meet their expected hashes. The > hashes were generated locally after checking the sha1's where > available. > > build-support/thrift/.gitignore | 7 ++++--- > build-support/thrift/Makefile | 47 > ++++++++++++++++++++++++++++++++++++++--------- > 2 files changed, 42 insertions(+), 12 deletions(-) > > > Diffs > ----- > > build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 > build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 > > Diff: https://reviews.apache.org/r/40323/diff/ > > > Testing > ------- > > I can now run `./build-support/jenkins/build.sh` green locally. > > I also got a hold of an OSX 10.10.5 box and was able to run > `./build-support/jenkins/build.sh` green on it using this change. > > > Thanks, > > John Sirois > >
