----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40324/#review106673 -----------------------------------------------------------
3rdparty/python/requirements.txt <https://reviews.apache.org/r/40324/#comment165413> Do you think it makes sense to add a comment here with a pointer to `3rdparty/python/BUILD` as the location for updating the mesos depdendencies? - Joshua Cohen On Nov. 15, 2015, 12:18 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40324/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2015, 12:18 a.m.) > > > Review request for Aurora, Joshua Cohen and Bill Farner. > > > Bugs: AURORA-1538 > https://issues.apache.org/jira/browse/AURORA-1538 > > > Repository: aurora > > > Description > ------- > > This lifts `mesos.interface` and `mesos.native` out of > `requirements.txt`, ties their versions together and isolates the > custom repository needed by `mesos.native` to its `python_requirement`. > > 3rdparty/python/BUILD | 26 ++++++++++++++++++++++++++ > 3rdparty/python/requirements.txt | 2 -- > pants.ini | 5 ----- > 3 files changed, 26 insertions(+), 7 deletions(-) > > > Diffs > ----- > > 3rdparty/python/BUILD 7ef81d13afa0089d7e8a779e71b53e0fc1848466 > 3rdparty/python/requirements.txt 3a78b754ad8e55308554119e279693053951cc6e > pants.ini 319d38e9a7af8055cac5bbce4a6ae0cbb38dc8d0 > > Diff: https://reviews.apache.org/r/40324/diff/ > > > Testing > ------- > > Successfully ran end-to-end with this change using a fresh vagrant > image and clean repo via: > ``` > vagrant destroy && \ > bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >