----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40323/#review106870 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On Nov. 17, 2015, 6:56 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40323/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 6:56 a.m.) > > > Review request for Aurora, Bill Farner and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This improves the isolation of the thrift build by building a local > pinned bison dep. For one, this gets thrift 0.9.1 building on Arch > Linux, a rolling release that is otherwise too modern in its libs to > successfully build thrift 0.9.1. > > Additionally, this change knocks out the checksumming TODO and now > checks all downloaded tarballs meet their expected hashes. The > hashes were generated locally after checking the sha1's where > available. > > > Diffs > ----- > > build-support/thrift/.gitignore ad6155ebe8671514b5bf5751f250b6cd71c858b7 > build-support/thrift/Makefile 51f37a959041536004f83a60d038f2116be8c8a9 > > Diff: https://reviews.apache.org/r/40323/diff/ > > > Testing > ------- > > I can now run `./build-support/jenkins/build.sh` green locally. > > I also got a hold of an OSX 10.10.5 box and was able to run > `./build-support/jenkins/build.sh` green on it using this change. > > > Thanks, > > John Sirois > >
