-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40466/#review107118
-----------------------------------------------------------


Master (7b1e848) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Nov. 19, 2015, 2:09 a.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40466/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 2:09 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This cleans up stringtemplate use in Aurora as directed by spikes on
> https://issues.apache.org/jira/browse/AURORA-987 that included upgrading
> to the stringtemplate 4.x series which errors when parameters used
> anywhere in a template - including un-triggered conditionals - are not
> bound.
> 
> The cleanups are vaild under stringtemplate 3.x as verified by testing
> the affected endpoints via the vagrant vm.
> 
>  
> commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logprinter.st
>  | 180 --------------------------------------------------
>  src/main/java/org/apache/aurora/scheduler/http/StructDump.java               
>        |   1 +
>  src/main/resources/org/apache/aurora/scheduler/http/slaves.st                
>        |   3 -
>  src/main/resources/org/apache/aurora/scheduler/http/utilization.st           
>        |   3 -
>  4 files changed, 1 insertion(+), 186 deletions(-)
> 
> 
> Diffs
> -----
> 
>   
> commons/src/main/resources/org/apache/aurora/common/net/http/handlers/logprinter.st
>  a9c98a4ecd6b1d9223a1ea6946ae27b814c9025b 
>   src/main/java/org/apache/aurora/scheduler/http/StructDump.java 
> 916269feff713a0ba6ae0efc853fd4f04f9beef6 
>   src/main/resources/org/apache/aurora/scheduler/http/slaves.st 
> 854a9d4a3dc0be6bdf0ea0ad6194ffce48039919 
>   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
> 4a8a07222d65681e77c90566be9dce9283c7be65 
> 
> Diff: https://reviews.apache.org/r/40466/diff/
> 
> 
> Testing
> -------
> 
> Manually tested the following endpoints:
> http://aurora.local:8081/structdump
> http://aurora.local:8081/slaves
> http://aurora.local:8081/utilization
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to