----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40675/#review107856 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On Nov. 24, 2015, 2:15 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40675/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 2:15 p.m.) > > > Review request for Aurora and Bill Farner. > > > Repository: aurora > > > Description > ------- > > We're building from a fresh tarball, so there is no need for a clean. > Importantly, the clean breaks building under centos 7 in > aurora-packaging, so this does less work and fixes that case. > > > Diffs > ----- > > build-support/thrift/Makefile 11d597d0a6ffbd7c13aea29803f9b7b38eb3c6df > > Diff: https://reviews.apache.org/r/40675/diff/ > > > Testing > ------- > > Locally green for `./build-support/thrift/thriftw 0.9.1 --version` > Bill confirmed the fix works for aurora-packaging CentOS 7. > > > Thanks, > > John Sirois > >
