-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40680/#review108019
-----------------------------------------------------------

Ship it!


Preempting Zameer's ack for a non-controviersial change on a currently red 
build.  Happy to personally follow up on any changes requested.

- Bill Farner


On Nov. 24, 2015, 7:06 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40680/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 7:06 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1545
>     https://issues.apache.org/jira/browse/AURORA-1545
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> The thrift Makefile now applies a patch that invalidates the grammar
> requiring a flex pass.  The openssl package is needed as well to support
> the new fingerprint checks in the Makefile.
> 
> Additionally, simplify the `pants.ini` used by both rpm and deb builds
> and turn on exception printing to help debug build failures more easily
> when packaging.
> 
>  builder/deb/ubuntu-trusty/pants.ini | 6 +-----
>  builder/rpm/centos-7/Dockerfile     | 2 ++
>  builder/rpm/centos-7/pants.ini      | 6 +-----
>  3 files changed, 4 insertions(+), 10 deletions(-)
> 
> 
> Diffs
> -----
> 
>   builder/deb/ubuntu-trusty/pants.ini 
> ed1a5ce8e8c3928085e4b84a882f3dcce02dadaa 
>   builder/rpm/centos-7/Dockerfile 05da048670235b90e5b7de0e88208fa2b42cc54a 
>   builder/rpm/centos-7/pants.ini 00074cb709f8f36a3506a9afa081197a66f94344 
> 
> Diff: https://reviews.apache.org/r/40680/diff/
> 
> 
> Testing
> -------
> 
> In aurora:
> ```
> $ git log -1 --oneline
> e3c5c37 Kill extraneous `make clean`.
> $ git archive --prefix=apache-aurora-0.11.0snapshot.2015.11.24/ -o 
> snapshot.tar.gz master
> ```
> 
> Then in aurora-packaging:
> ```
> $ ./build-artifact.sh builder/rpm/centos-7 ../aurora/snapshot.tar.gz 
> 0.11.0snapshot.2015.11.24
> ...
> artifacts/aurora-centos-7/dist/rpmbuild/BUILDROOT:
> 
> artifacts/aurora-centos-7/dist/rpmbuild/RPMS:
> x86_64
> 
> artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64:
> aurora-executor-0.11.0snapshot.2015.11.24-1.el7.centos.aurora.x86_64.rpm   
> aurora-scheduler-debuginfo-0.11.0snapshot.2015.11.24-1.el7.centos.aurora.x86_64.rpm
>         repodata
> aurora-scheduler-0.11.0snapshot.2015.11.24-1.el7.centos.aurora.x86_64.rpm  
> aurora-tools-0.11.0snapshot.2015.11.24-1.el7.centos.aurora.x86_64.rpm
> 
> artifacts/aurora-centos-7/dist/rpmbuild/RPMS/x86_64/repodata:
> 2677071bd0d93ff38cf81a0fe2eb1a5dfea721f792f8d49486998448b5003ae2-primary.sqlite.bz2
>   
> 8b2aa6f9cef87eb14360f1e283339a32fcafe54a39d9d1c70d243c4108271cec-other.sqlite.bz2
>         
> c8acb9b6e6de62fa11d491fd799d726e54edea426960e8b3bb370bc395ca17a6-filelists.xml.gz
>       repomd.xml
> 26c6ffa7fcd1fc681d681a863b73374cd7600bc2c3cebfed7065ecd45571ce1e-primary.xml.gz
>       
> c009bb8b03871965fb8625ea4ffbabeca6297745d6fb3d204eff7832ff6a3e21-other.xml.gz 
>    
> caff7d9fea5245f8dd4d0269fb661e83e6755283d640f44c5f0922623179c262-filelists.sqlite.bz2
> 
> artifacts/aurora-centos-7/dist/rpmbuild/SOURCES:
> aurora.init.sh        aurora.logrotate  aurora.service  aurora.startup.sh  
> aurora.sysconfig  aurora.tar.gz  clusters.json  thermos-observer.init.sh  
> thermos-observer.logrotate  thermos-observer.service  
> thermos-observer.startup.sh  thermos-observer.sysconfig
> 
> artifacts/aurora-centos-7/dist/rpmbuild/SRPMS:
> aurora-scheduler-0.11.0snapshot.2015.11.24-1.el7.centos.aurora.src.rpm
> ```
> 
> It may be the case that debs were already known-working, but I wasn't
> sure and confirmed via:
> ```
> $ ./build-artifact.sh builder/deb/ubuntu-trusty ../aurora/snapshot.tar.gz 
> 0.11.0snapshot.2015.11.24
> ...
> 9b6e631586e9
> Produced artifacts in artifacts/aurora-ubuntu-trusty:
> artifacts/aurora-ubuntu-trusty:
> dist
> 
> artifacts/aurora-ubuntu-trusty/dist:
> aurora-doc_0.11.0snapshot.2015.11.24_all.deb  
> aurora-executor_0.11.0snapshot.2015.11.24_amd64.deb  
> aurora-scheduler_0.11.0snapshot.2015.11.24_amd64.deb  
> aurora-tools_0.11.0snapshot.2015.11.24_amd64.deb
> ```
> 
> Looks like the thrift issue though is side-stepped via:
> ` 
> http://people.apache.org/~jfarrell/thrift/0.9.1/contrib/deb/ubuntu/12.04/$THRIFT_DEB`
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to