Re: Review Request 40922: AURORA-1548 | (Thermos) Add ability to forward process output to stdout

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40922/#review108989
-----------------------------------------------------------


Master (676ee5b) is red with this patch.
  ./build-support/jenkins/build.sh

                     
src.test.python.apache.aurora.tools.thermos_observer_entry_point                
.....   SUCCESS
                     src.test.python.apache.thermos.cli.common                  
                     .....   SUCCESS
                     src.test.python.apache.thermos.cli.main                    
                     .....   SUCCESS
                     src.test.python.apache.thermos.cli.commands.commands       
                     .....   SUCCESS
                     src.test.python.apache.thermos.common.test_pathspec        
                     .....   SUCCESS
                     src.test.python.apache.thermos.core.test_process           
                     .....   FAILURE
                     
src.test.python.apache.thermos.core.test_runner_integration                     
.....   SUCCESS
                     src.test.python.apache.thermos.monitoring.test_disk        
                     .....   SUCCESSPASSED
                     
src/test/python/apache/thermos/core/test_process.py::test_tee_class 
PASSED
                     
src/test/python/apache/thermos/core/test_process.py::test_process_tee 
PASSED
                     
                     ==================== FAILURES ====================
                     ______________ test_simple_process _______________
                     
                         def test_simple_process():
                           with temporary_dir() as td:
                             taskpath = make_taskpath(td)
                             sandbox = setup_sandbox(td, taskpath)
                         
                             p = TestProcess('process', 'echo hello world', 
0, taskpath, sandbox)
                             p.start()
                             rc = 
wait_for_rc(taskpath.getpath('process_checkpoint'))
                         
                             assert rc == 0
                             stdout = 
taskpath.with_filename('stdout').getpath('process_logdir')
                             assert os.path.exists(stdout)
                             with open(stdout, 'r') as fp:
                     >         assert fp.read() == 'hello world\n'
                     E         assert '' == 'hello world\n'
                     E           + hello world
                     
                     src/test/python/apache/thermos/core/test_process.py:94: 
AssertionError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.thermos.core.test_process.xml
 
                     = 1 failed, 7 passed, 1 warnings in 1.90 seconds 
=
                     
FAILURE


15:35:10 04:33   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Dec. 4, 2015, 2:54 p.m., Martin Hrabovcin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40922/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2015, 2:54 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1548 | (Thermos) Add ability to forward process output to stdout
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 0d02dc1 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 14e8b4b 
>   src/main/python/apache/thermos/core/process.py fe95cb3 
>   src/main/python/apache/thermos/core/runner.py f949f27 
>   src/main/python/apache/thermos/runner/thermos_runner.py bd8cf7f 
>   src/test/python/apache/thermos/core/test_process.py 5e6ad2f 
> 
> Diff: https://reviews.apache.org/r/40922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Hrabovcin
> 
>