----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41048/#review109186 -----------------------------------------------------------
Thanks for looking into this! Just a minor comment below. src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java (line 116) <https://reviews.apache.org/r/41048/#comment168660> Since there are no callers other than the reconciler unit test, I'd suggest moving this code into the test itself. - Maxim Khutornenko On Dec. 7, 2015, 7:30 p.m., Tengfei Mu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41048/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 7:30 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Bugs: AURORA-1547 > https://issues.apache.org/jira/browse/AURORA-1547 > > > Repository: aurora > > > Description > ------- > > set TaskStatus.slave_id field in TaskReconsiler > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 2cdb2f21202c09b6308e3cfa75d2255699b4c2e5 > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > c797914ded51cd123dddef188373fe58e190773a > > src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java > 1308a1c9884e7759e6139787710b367bbf9cd4e9 > > Diff: https://reviews.apache.org/r/41048/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Tengfei Mu > >
