> On Dec. 8, 2015, 5:31 p.m., Maxim Khutornenko wrote: > > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java, line 99 > > <https://reviews.apache.org/r/41074/diff/1/?file=1155647#file1155647line99> > > > > Fits to previous line. > > Bill Farner wrote: > Done, also converted to method reference. Also ran a broader search for > conversions to method refs and found/converted ~50.
Thanks! I was going to mention but somehow it escaped me. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41074/#review109346 ----------------------------------------------------------- On Dec. 8, 2015, 5:08 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41074/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 5:08 a.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This is almost entirely IDE-assisted. There were some spots that required > hand-editing (notably casting the argument to `storage.write`). > > The overall stats are nice, a reduction of about 1300 lines: > ``` > 114 files changed, 1982 insertions(+), 3292 deletions(-) > ``` > > > Diffs > ----- > > > commons-args/src/main/java/org/apache/aurora/common/args/apt/CmdLineProcessor.java > 5abb06b1d41f3265d9d46c600ba193ce19d21188 > > commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java > d06ec69cb57d9c411ae33b301489f6460197dcc7 > commons/src/main/java/org/apache/aurora/common/args/ArgFilters.java > 9a4d441023fd9eea868fd069c197eb002d98f0ab > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java > cc4710cb5f559a108b140489a981a9d2c195b75b > commons/src/main/java/org/apache/aurora/common/args/Args.java > ad0b299057e787a9587822e7778bd360f77e1678 > commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java > 051e3f93ef17de90b7bffaa74fc6b54965927424 > commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java > c1fe1c73c46da21c471b2669dbb8207b7c468054 > commons/src/main/java/org/apache/aurora/common/args/Parsers.java > 62564a62d255e640e5790ed2e103ba8425a4c15b > commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java > 3da1812abfdb30f12737b19f5e87bc14a02d4c3f > > commons/src/main/java/org/apache/aurora/common/args/constraints/RangeNumberVerifier.java > 27250944a60f906a4c220771e9948ed0297ee76c > commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java > 02c10ed067c8395a2688cd69d4d73d5fd17774ff > commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java > 1e12b06e284cd2e33b63b3690abd3dcd78f9e777 > commons/src/main/java/org/apache/aurora/common/base/Closures.java > d6cb82a30a8c6292bab0fa007dce2f54f6b66435 > commons/src/main/java/org/apache/aurora/common/base/Commands.java > 8a88ae336f57fcdafb984cc3418dcd960da0028d > commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java > 072159e79b2d8872f39dfbba9f6a1d27295f1a7a > commons/src/main/java/org/apache/aurora/common/collections/Pair.java > b1f9b6336aa8b8d0ff9e611dc2ad1dc8068ef7f3 > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java > aaaa348a8c923118da3b4399afb1a6f09d904c3b > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSource.java > 8039def73377b0e56c3106876dc89e9183cd55a1 > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/VarsHandler.java > d1f23de1a440d47a7754af2c8418e2c4e96bbb84 > commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java > 03df9b6f7d31d8567a6bd135654eb39026c375d7 > commons/src/main/java/org/apache/aurora/common/stats/Rate.java > ff29c39863f044db7fde0fff315621644393429d > commons/src/main/java/org/apache/aurora/common/stats/Ratio.java > c332dd3af5712bfb8ed174c2285cac4d30394acc > > commons/src/main/java/org/apache/aurora/common/testing/easymock/EasyMockTest.java > 403147527eab46e9c23ab5690d885a6c1deb1c30 > commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java > e789f804ecc0053d4605927dc981311af1df94c8 > commons/src/main/java/org/apache/aurora/common/util/StateMachine.java > 9fbfbb9012414a19cf752d69b48f2e937f4497e7 > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java > b10a40327a062b354b42249097c89bf3fbecb1e8 > commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java > 99a15fe8d58138ebd264d858bff842316928db06 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > bb6fbced0adc0920592ec14f03a84895829d8812 > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > 1761ab70a32656af13a311bcc02f716fdc0ad067 > config/legacy_untested_classes.txt 07e49b11050f8b9be63d5b95cfcdb7800e15c7e5 > src/main/java/org/apache/aurora/GuiceUtils.java > 78b60c26231ff070f08f236f38c8fb58ca9f8d60 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > 7003b2f0b73bf050ae243da4da4c844e77cdb04b > src/main/java/org/apache/aurora/scheduler/Resources.java > f7d105eca961da2b5b445d4a0670e3d5e9bf89b2 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > 29331e075b29f0994b4ce4dc8ce602b01b307f0a > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 6d940d17fcb95a221d7d125cc13423e384e4144e > src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java > 311257921df7dca9c2002fbf4c8569d297207c58 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > da9f22279a4cd1005a85e8b78398ed57ac6cac34 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 54814b2b104bb0140d73b314f70ed42d9e0ec454 > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > ad66cd86567497dc3e75d75e278540c75b88d89d > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 84e6be53510a6e7a3feb4ed54761c37fc6e17c4d > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > 9b71802c9282b16736f7b4abe26c0db8d6c1c724 > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java > e377fd86cb00b06d6cb5ef1b36df496001a26429 > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java > a71676eec6171bf61c5a6eb1678e99c738d54200 > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > 2065c45ff8523b9c9275574a09aae748776a3cef > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java > 51376798d3e4fb7c86802e4afbe7f2c7191c0e72 > src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java > 2b47821bf3c0f4a78f781ed3c8e72a69906651b5 > src/main/java/org/apache/aurora/scheduler/http/Locks.java > e275dd7410d59c2ec2721f4a7981ba00473600ae > src/main/java/org/apache/aurora/scheduler/http/Maintenance.java > 526875906adfec94bdb3aadfb045bdac942ed483 > src/main/java/org/apache/aurora/scheduler/http/Offers.java > 15f158252ee604ac643af62d34189c1d5f75408a > src/main/java/org/apache/aurora/scheduler/http/Quotas.java > e1bf0cb537efdbc290f7867936638c6cd675a819 > src/main/java/org/apache/aurora/scheduler/http/Services.java > 71833707aa2f6c2c3643a2d6fd21f3f6ef8e19fc > src/main/java/org/apache/aurora/scheduler/http/Slaves.java > a9fef25595d616f0fbbb7c5ad6de39184a60002a > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > d66f4cedff2210fb9bcc15c10cab2709761a5de9 > src/main/java/org/apache/aurora/scheduler/http/Utilization.java > 147ef0b63a1116dad4ce71baa01b8fcab365ec64 > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java > 690e82e0e76025596b44c3720950fe67364f378f > > src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java > 41f48b938a9a81d9640267c87ae64d7b5c6d78e3 > > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java > 2a8a8f6ebe1cab3862b941ce143160af137c8a97 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java > 98f3c1fe3069b66aab92d22a625b375f846b278a > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java > 4afd077a5665d5d9cf3cc18b6e0a0c660303686c > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java > 64ab611d7483cd9dacda6cdb00d1324fee48b9f6 > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > 0743cb09bc9ec5375513ac89227c7d839f197324 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 1b03f47b7d7dcc9b855bce40dc9949ce1316838f > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java > 35c30f12626301203772833b1ff76ba7e5042a83 > src/main/java/org/apache/aurora/scheduler/metadata/NearestFit.java > 8788f4d32a36fb63c1ab552730a6279cf19cfcaf > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > 88c9f667b7abc79f6cbedb575b631b68112c1d74 > src/main/java/org/apache/aurora/scheduler/preemptor/BiCache.java > ffc109e8ab5626098e6b64f5491faa53bdc1e960 > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 506176769e172b7e9f4ba05c486fe6ab550fb5c3 > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java > edfa20222a680a5875aa28c7f61619ba4c1a9c8d > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > fc9dac8caf9e148355fbf5616f8c440ff32f1ea2 > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 96393ebe396262b97f9cb80404e99231b3479c23 > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > bb1fc8b2d3e57184db2d1873606dbbe4b398b6e6 > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > a12910e234df73875717d9cd00352e61c68420ba > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > c797914ded51cd123dddef188373fe58e190773a > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskTimeout.java > bfe094ba93421d0b2047261b4ef6fa27c21161f3 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java > 66d5a10f23be87fa483ba14a2477b97d43f0f45e > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > f1b11d6513546231c2510805e4a0acf23367a761 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskThrottler.java > 837bab7afde4210f7ada8381c977024a4c597c4a > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > 54fa45a7312283970ad16feddd46dd99f308648c > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > 88b2d106047d38a7b772116231afbce3e055b590 > src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java > 4827a0da2ffba56ab41cb749ea77a7ff67356dca > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java > 76600220e8f481312740a55d28b06b5d81cf9bdb > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > 617ee549cc79f3c95c70ceaceca6e26ccebd1681 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > f27c93b2a59d9efd4ed8ba0fd314a33e67a9c8e0 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > de7ebb382f56854dc2315d3793217ef007d7fbfe > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java > 9ace5b0813dfffaa9a79dc1982c475cf587d8edf > src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java > c8ef858558669a8370795ab66b5b4204049a34e9 > src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java > ced6b678bf74618d8d8fffba8670a34dcd416d43 > src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java > 6399e78b23b5dfeaf4bbb80d58215cea0561dae0 > > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java > 2136154182dbfa899772072ac92629066461a3fe > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > f699ba5c0018d683819c531102ef49478f9970cf > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java > a0483f4731f1e0c775904e45509ac4a65c847831 > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > 142e4ac6c762c5e99e3340d77ae257ea503d76a4 > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > 18daa05b9af9892fc930660f9bb75bfeb8649fc1 > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java > c4e18d4df323be7c980a27956734dff25b925d05 > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > 6af059da128ea46211deeb1006f3681fd6e1678c > src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java > ee3ff6cb9f4cec06a5ae4e4fd0a0f8d7ae663176 > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java > 765213269c3014866ed8a5deafea9b6f667e1500 > src/main/java/org/apache/aurora/scheduler/storage/db/DbStorage.java > dd7e1d384b7658645420ff36bf803e7043c047e9 > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java > df6e583a5225e8728bb87538364b8b4102d33155 > src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java > 9b6add95cf1f03e9707678764a35e47cfb7973d1 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > adbf4593cce110fde9f30527a8cd01710ebe2fe2 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java > 79536f19c5fa29bdb18941d6aeb2e3f9c3c6044e > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > ed1fffe362c1ec893598847cad5c0cfbe962c11a > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 072fe459e1422d6d59499b17440232ab112254ba > src/main/java/org/apache/aurora/scheduler/storage/mem/Util.java > 65043fe62a91cc00abe662c92b5e8da2d2896cd0 > src/main/java/org/apache/aurora/scheduler/testing/FakeStatsProvider.java > 5d0eaba346bf9dbb9407114855ee996fd9a907f2 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 358b80c0aebaddcb89337d9ea2c23fab7a39f1e3 > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 2d7c22383bc10c957a17e446ccdceb5d77613a06 > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > 79b677d6ead2abb5e28f5ed75287de2ee7742027 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > a7b9b07be9585624120471c70ae733d87360ee1f > src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java > ca253886c0db94e76163a9ef3b2be19ab629677c > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > 43ff094cdddbc972f64f90ebb946fd80fdda2b97 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java > 1dbab1ea7fc8578c92d0e0e265e8c40526666296 > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java > 465061149108bc1890bd07b502312df3b8aa7437 > > Diff: https://reviews.apache.org/r/41074/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
