-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41154/#review109638
-----------------------------------------------------------
Master (8613f7b) is red with this patch.
./build-support/jenkins/build.sh
+from gen.apache.aurora.api.ttypes import AssignedTask, ExecutorConfig,
TaskConfig
class TestHealthChecker(unittest.TestCase):
ERROR:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/http_lifecycle.py
Imports are incorrectly sorted.
---
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/http_lifecycle.py:before
2015-12-09 23:45:05.950543
+++
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/http_lifecycle.py:after
2015-12-09 23:50:33.484197
@@ -18,6 +18,7 @@
from twitter.common.quantity import Amount, Time
from apache.aurora.common.health_check.http_signaler import HttpSignaler
+
from .common.task_runner import TaskError, TaskRunner
ERROR:
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py
Imports are incorrectly sorted.
---
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py:before
2015-12-09 23:45:05.950543
+++
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/python/apache/aurora/executor/common/health_checker.py:after
2015-12-09 23:50:33.524799
@@ -12,18 +12,19 @@
# limitations under the License.
#
+import os.path
import threading
import time
import traceback
+from mesos.interface.mesos_pb2 import TaskState
from twitter.common import log
from twitter.common.exceptions import ExceptionalThread
from twitter.common.metrics import LambdaGauge
-import os.path
from apache.aurora.common.health_check.generic import GenericHealthCheck
from apache.aurora.common.health_check.http_signaler import HttpSignaler
-from mesos.interface.mesos_pb2 import TaskState
+
from .status_checker import StatusChecker, StatusCheckerProvider, StatusResult
from .task_info import mesos_task_instance_from_assigned_task, resolve_ports
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On Dec. 9, 2015, 11:04 p.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41154/
> -----------------------------------------------------------
>
> (Updated Dec. 9, 2015, 11:04 p.m.)
>
>
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
>
>
> Bugs: AURORA-1551
> https://issues.apache.org/jira/browse/AURORA-1551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding support for non-HTTP health checks.
>
>
> Diffs
> -----
>
> 3rdparty/python/requirements.txt cfef18ee66b0f92d83c53dacb6d9376fc2e50445
> docs/configuration-reference.md 364292998bebb233d300fe59c9ea42b216deee81
> src/main/python/apache/aurora/common/BUILD
> 5fce3d0d29d2a38c6563b4d9be963532e595ee19
> src/main/python/apache/aurora/common/health_check/BUILD PRE-CREATION
> src/main/python/apache/aurora/common/health_check/__init__.py PRE-CREATION
> src/main/python/apache/aurora/common/health_check/generic.py PRE-CREATION
> src/main/python/apache/aurora/common/http_signaler.py
> a3193f3259276ec23d37f45839afe3c387cff6b1
> src/main/python/apache/aurora/config/schema/base.py
> 398f737bed9ef02ce4a5636896d6587bce26501e
> src/main/python/apache/aurora/executor/common/health_checker.py
> 03fdf0afef120c365c6ffad09e152780eed7e351
> src/main/python/apache/aurora/executor/http_lifecycle.py
> 6d578cceb56375425ccac1cbfbbcd0add60f20e9
> src/test/python/apache/aurora/common/BUILD
> 2556c32842b3cf7040cb3c41172a0d9c365cb649
> src/test/python/apache/aurora/common/health_check/BUILD PRE-CREATION
> src/test/python/apache/aurora/common/health_check/__init__.py PRE-CREATION
> src/test/python/apache/aurora/common/health_check/test_generic.py
> PRE-CREATION
> src/test/python/apache/aurora/common/test_http_signaler.py
> f68c71a6765f7f0b93c8c50662515b5742344f35
> src/test/python/apache/aurora/executor/common/test_health_checker.py
> 27c71711d52f757ed1552db4accda671a6bdafdd
>
> Diff: https://reviews.apache.org/r/41154/diff/
>
>
> Testing
> -------
>
> Added unit tests.
> Ran e2e test.
> Tested expected behavior on virtual Mesos cluster.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
