----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41190/#review109682 -----------------------------------------------------------
Ship it! Master (8613f7b) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Dec. 10, 2015, 4:03 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41190/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 4:03 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Bill Farner. > > > Bugs: AURORA-1550 > https://issues.apache.org/jira/browse/AURORA-1550 > > > Repository: aurora > > > Description > ------- > > This reverts commit 0e62780c48ecc89571482f5b6663914147f96234. > > Above and beyond the clean re-application of > 0c98e8a82177f39534db3a49162582aeb1739728 is a fixup of > the gradle idea plugin configuration to handle apt. > > This adds some manipulation of the idea project and module model to > support gradle (sub)projects that use code generating annotation > processors. > > .gitignore > | 3 + > build.gradle > | 88 +++++++++++++++-- > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java > | 185 ----------------------------------- > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > | 13 ++- > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > | 266 -------------------------------------------------- > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > | 5 +- > 6 files changed, 100 insertions(+), 460 deletions(-) > > > Diffs > ----- > > .gitignore 6c37128b5d02b0e52eb467be3652a37b10d7bc06 > build.gradle d4efe3a4ed3a8f6a4f72512b2cbb903b80e8a04a > src/main/java/org/apache/aurora/scheduler/storage/ForwardingStore.java > b8bd9185cacc6b113b64a13a1b670fac202c795e > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 89dd8aacafaa3a68afb8d4a0f4a7cba14cfef503 > src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java > 2de178302d3c9aa9a7b23a9eb7ecb6e2f3b40819 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 1415f0cacc694aa7cf0d25e836e764a96fbb8ae2 > > Diff: https://reviews.apache.org/r/41190/diff/ > > > Testing > ------- > > The project generated by `./gradlew idea` now compiles inside > IDEA, tests can be run and debugged in the IDE, jmh benchmarks > can likewise be run, and all generated code is mapped and > explorable. > > > Thanks, > > John Sirois > >