> On Dec. 10, 2015, 4:38 a.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/thermos_task_runner.py, line 364 > > <https://reviews.apache.org/r/41201/diff/1/?file=1158680#file1158680line364> > > > > Is it really necessary that this is implemented docker specific? I > > believe even if you don't run docker, one could be interested in that > > feature. > > Kasisnu Singh wrote: > This is only handling the case where --preserve_env is set for docker > containers. The option to set that will still be available at the runner. I > can modify the logic to handle other cases. > > I think I missed the simplerun use-case. Anything else?
I agree with the surprising behavior, but i have a broader concern - this patch will change behavior for anyone using docker containers, which we should not do. I think it's best if `--preserve_env` is plumbed up to `thermos_executor_main.py`, and the behavior is toggled there, defaulting to existing behavior of scrubbing the env. - Bill ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41201/#review109748 ----------------------------------------------------------- On Dec. 10, 2015, 4:24 a.m., Kasisnu Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41201/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 4:24 a.m.) > > > Review request for Aurora. > > > Repository: aurora > > > Description > ------- > > Preserve env variables for tasks in docker > > > Diffs > ----- > > src/main/python/apache/aurora/executor/thermos_task_runner.py > 14e8b4bd539d2c295582d93fa01b5613345c1758 > src/main/python/apache/thermos/core/process.py > f214bccbd6f3be795e0fa9a259d27b01b81ab655 > src/main/python/apache/thermos/core/runner.py > f949f279a071c6464b026749f51afc776102f2aa > src/main/python/apache/thermos/runner/thermos_runner.py > bd8cf7f4cda54b6be72dad64f9446eedeb132211 > > Diff: https://reviews.apache.org/r/41201/diff/ > > > Testing > ------- > > Ran ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh with no failures > and did manual testing for env variables in containers. > > > Thanks, > > Kasisnu Singh > >
