> On Dec. 10, 2015, 7:12 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 
> > 110
> > <https://reviews.apache.org/r/30695/diff/4/?file=1147020#file1147020line110>
> >
> >     What is the unit?  FWIW i'm typically fond when the arg calls out the 
> > unit to make it unambiguous.  I'd also be in favor of making the unit `_mb` 
> > as a reasonable unit.

SGTM - I'll update with the unit suffix on the arg + update the help 
documentation.


> On Dec. 10, 2015, 7:12 p.m., Bill Farner wrote:
> > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 
> > 104
> > <https://reviews.apache.org/r/30695/diff/4/?file=1147020#file1147020line104>
> >
> >     It would be super helpful to list the acceptable values.

Sure, I'll add them.


> On Dec. 10, 2015, 7:12 p.m., Bill Farner wrote:
> > docs/deploying-aurora-scheduler.md, line 182
> > <https://reviews.apache.org/r/30695/diff/4/?file=1147019#file1147019line182>
> >
> >     This has diverged from the actual arg in the code.

Yeah, see my comment with the last change :).

I wanted to make sure that everyone was on board with the behavior before I 
finalized the documentation. As things stand right now, if you provide the 
flags through the scheduler it becomes the behavior for every process, 
regardless of what you have set in your job config. This is (selfishly) 
consistent with the original behavior of the patch, but I just wanted to make 
sure that everyone was onboard with that since it deviates a bit from the 
earlier conversation in which the flags would supply _default_ values in the 
absence of any explicit setting in the job config.

We could meet in the middle and add an extra flag to toggle that behavior 
(override vs. default) but I'm not sure if you think that would overcomplicate 
things.


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30695/#review109834
-----------------------------------------------------------


On Nov. 25, 2015, 5 p.m., George Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30695/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 5 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Brian Wickman.
> 
> 
> Bugs: AURORA-95
>     https://issues.apache.org/jira/browse/AURORA-95
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Implements log rotation in the Thermos runner.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 8a1e68e5d54e9b8b66139bfc731563668584fa77 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> b3e8bf1e924999306e0b8a1314273b22c51028e7 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 14e8b4bd539d2c295582d93fa01b5613345c1758 
>   src/main/python/apache/thermos/config/schema_base.py 
> f9143cc1b83143d6147f59d90c79435d055d0518 
>   src/main/python/apache/thermos/core/process.py 
> fe95cb3be01b47616596bd78cb9a919b2e8bd978 
>   src/main/python/apache/thermos/core/runner.py 
> f949f279a071c6464b026749f51afc776102f2aa 
>   src/main/python/apache/thermos/runner/thermos_runner.py 
> bd8cf7f4cda54b6be72dad64f9446eedeb132211 
>   src/test/python/apache/thermos/core/test_process.py 
> 5e6ad2fca616b840299bd9ca1614c82c5c39e992 
> 
> Diff: https://reviews.apache.org/r/30695/diff/
> 
> 
> Testing
> -------
> 
> ./pants test src/test/python/apache/thermos/core:all
> 
> 
> Thanks,
> 
> George Sirois
> 
>

Reply via email to