----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41392/#review110425 -----------------------------------------------------------
Reviewer notes. build.gradle (line 89) <https://reviews.apache.org/r/41392/#comment170284> positive side-effect: brings us up to the latest `servlet-api` version build.gradle (line 159) <https://reviews.apache.org/r/41392/#comment170285> Directly depending on `rs-api` was causing trouble since it's actually embedded in jersey for the rest of the app. This resolved some run-time classpath issues. build.gradle <https://reviews.apache.org/r/41392/#comment170287> These were unused. src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java <https://reviews.apache.org/r/41392/#comment170290> This was moved, and can now be applied to the entire server. Look for `getGzipHandler`. src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java (line 377) <https://reviews.apache.org/r/41392/#comment170289> Relevant comment from `RequestLogger.java`: /** * A copy of twitter RequestLogger from twitter commons, which is a port of jetty's NCSARequestLog * to use java.util.logging. This clone exists to allow us to upgrade to jetty 7. * <p> * TODO(wfarner): Replace this with jetty's Slf4jRequestLog once we upgrade to jetty 8. */ - Bill Farner On Dec. 14, 2015, 9:49 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41392/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 9:49 p.m.) > > > Review request for Aurora and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Jetty 7 and 8 are are at EOL and in maintenace mode. This brings us up to > the latest. > > > Diffs > ----- > > build.gradle cb3c45bf25bd22884302c4b525daf840c873fd7c > src/main/java/org/apache/aurora/scheduler/http/HttpStatsFilter.java > 7ffd10573b31089c850802854b344433d64ed08b > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > c78315da4b7a23fac274e10e2c8bcb4001a0d94c > src/main/java/org/apache/aurora/scheduler/http/RequestLogger.java > ef6a84879a2a90d2c7ff2a81a723b20c56d550c2 > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > 791fd45646f4b353122e723b43b22b44baf5279b > src/test/java/org/apache/aurora/scheduler/http/RequestLoggerTest.java > a2f786a588633e82890c2e8d695a5be2fde45452 > src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java > 3a18e94e3459b020f86a4f50e4f7e745ed33e670 > > Diff: https://reviews.apache.org/r/41392/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
