-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41413/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 3:31 p.m.)


Review request for Aurora and Zameer Manji.


Changes
-------

Removed unnecessary sourceSets assignment.


Repository: aurora


Description
-------

The most interesting parts of this essentially amount to an XML refactor.  I 
tried to pull the common style rules into `config/pmd/common.xml` and used the 
other two for test- and main-specific rules.

I originally didn't do this because i wasn't aware we could have different 
rules for test/main code.  Turns out you can!


Diffs (updated)
-----

  build.gradle a91370f793be9b86e54cf708b5ec1e87141bfc5c 
  config/pmd/common.xml PRE-CREATION 
  config/pmd/custom.xml 763051b01f468cb3a60a0f068b0d460700f1a6d6 
  config/pmd/test.xml PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 
3a6d3e46f10797a9f0e4d63eff0f0724bf969f42 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
73f74ea90dfeda8643bcebe072ca3abd179c0510 
  src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java 
73ea3cbbf1458ffeecb4bf9714b1eb37bfead32f 
  src/test/java/org/apache/aurora/scheduler/app/local/simulator/Events.java 
f36c1ffc515241a8bc2b8c606e4bb7188fd1b73c 
  src/test/java/org/apache/aurora/scheduler/app/local/simulator/FakeSlaves.java 
9274e7b1aa4c01b96a0a3dfa1157a2eaa318a638 
  
src/test/java/org/apache/aurora/scheduler/app/local/simulator/events/Started.java
 PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/async/AsyncModuleTest.java 
259ed867730f80dd56137347460a2625c9660e73 
  src/test/java/org/apache/aurora/scheduler/cron/CrontabEntryTest.java 
57e0241f60868b1cc29f4c228dd58caadb29b466 
  src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java 
9cca71b329d40ad288c882366eb39b0493d5a893 
  
src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java
 ce6426b67c2847115a11712fdd4972fcd34115bf 
  src/test/java/org/apache/aurora/scheduler/http/H2ConsoleModuleIT.java 
6ffb3704aff592ab9c3ede968f72f5e7f37f5100 
  src/test/java/org/apache/aurora/scheduler/http/JettyServerModuleTest.java 
abf823a3efba42507fb5f7e61f570e540b12fa1a 
  src/test/java/org/apache/aurora/scheduler/http/MnameTest.java 
8f76230d7f80b42b95a8369e27dcf07bdf601335 
  src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java 
d0c4449f78d445a2936b4bf2993c5a42ed126b4b 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java 
6dc65b55aaaedc1487b5450729786ee6b0f1a217 
  src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 
aa3a85ac85a88a83a9801bb3c4494553141d3a9b 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java 
23db909c1a229687b1d58894731406a721aba7d5 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ModuleParserTest.java
 42eec1244aa2a0b99d82464e6efad24ef30e007f 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilterTest.java
 f35dcb8eb932ae7224847d53f69c411ffa680592 
  
src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosPermissiveAuthenticationFilterTest.java
 6eb82b542a04828299ca66dc19e81eaddacd500c 
  src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java 
ecef202d8545df16a9bcd27e265b3022cc1de092 
  
src/test/java/org/apache/aurora/scheduler/mesos/SchedulerDriverServiceTest.java 
45a8a5dacbcab5eb7caacdd6a4b5289217c9284e 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java
 49002d03b190b8642b6251f4d1fbd6663ee6becc 
  
src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java
 fca4c81df6d3ee1c4edaeec9ac21697e2f22e113 
  src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorImplTest.java 
e9a37036ed7154ca078811ff08bbac7fddba56e1 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
e68fc1d767be2a95410c28607466d2b6f1fa0436 
  
src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java
 d1675c68ff39b00099c60c0e85d84732f031adb1 
  src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java 
ecfa895ddf78babae48dd16f8bbbf67500a65b38 
  src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java 
d36f5652357e06d6c8944d907ee011b91e84e9c6 
  src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java 
c51d9f99f1434e9f7c3a17be3d093bf7308816be 
  src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java 
c3a803e9a0edce3b864d337a0b1301808186fe21 
  src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
c29a044e8dd8097f0ede54e5718bcf2806c19579 
  src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 
c025f4e44390c69a164e62e5612019ea41536fd4 
  
src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java 
f5f5bda21b8567ecb304cae746958ae1df97eeb1 
  src/test/java/org/apache/aurora/scheduler/storage/db/DbStorageTest.java 
214e287d71c3bceb66d64332c0dd1b7389b7aaaf 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java 
9cae0c43cda74bf9a41bd9a530992834540ec15d 
  src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 
6f31206ca056dceea56e78b26428a570247c15e0 
  
src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java
 269e89ab5e118bf6c50d10d5ef0685a1bbab1fbb 
  
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java
 5e054a7c97eaa27f2f58cc613a215ae52dee17f2 

Diff: https://reviews.apache.org/r/41413/diff/


Testing
-------


Thanks,

Bill Farner

Reply via email to