> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/config.py, line 90
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165615#file1165615line90>
> >
> >     "...are deprecated and will be removed in next release."
> >     
> >     The last sentence needs some rephrasing as well.

Done.


> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/config.py, lines 103-104
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165615#file1165615line103>
> >
> >     Unfinished comments?

Done.


> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/client/config.py, line 105
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165615#file1165615line105>
> >
> >     s/to_deprecate/deprecated

Done.


> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, line 245
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165618#file1165618line245>
> >
> >     This should be HTTP_DEPRECATION_WARNING from config.py.

Done.


> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/test/python/apache/aurora/client/test_config.py, line 218
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165618#file1165618line218>
> >
> >     tabbing is off (here and below)? should be 4 spaces for continuation.

Done.


> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/executor/common/health_checker.py, line 241
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165617#file1165617line241>
> >
> >     Please, create removal ticket, link it to AURORA-1559 and mention it 
> > here.

Done: AURORA-1563.


> On Dec. 16, 2015, 4:40 a.m., Maxim Khutornenko wrote:
> > src/main/python/apache/aurora/config/schema/base.py, line 39
> > <https://reviews.apache.org/r/41428/diff/2/?file=1165616#file1165616line39>
> >
> >     Please, document new fields in configuration-reference.md and mark old 
> > ones as deprecated.

Done.


- Dmitriy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41428/#review110612
-----------------------------------------------------------


On Dec. 16, 2015, 7:15 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41428/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 7:15 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji.
> 
> 
> Bugs: AURORA-1562
>     https://issues.apache.org/jira/browse/AURORA-1562
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Refactoring HealthCheckConfig into separate structs
> 
> 
> Diffs
> -----
> 
>   docs/configuration-reference.md 07149c7f49371e39b70e8744d60affeffd73c77f 
>   src/main/python/apache/aurora/client/config.py 
> 161c3627db0afa8fdd8afff5abf6a94556f53180 
>   src/main/python/apache/aurora/config/schema/base.py 
> e752482b95ae6377d0cf12cf0ecf0fa60e2a5d46 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> cba4e8c879fae2b9f56a36bf8fa4b702163667d1 
>   src/test/python/apache/aurora/client/test_config.py 
> 8fd112fd8a10120f57324d8efec22a009b93404b 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 8561abc3e7df8803785b70064bb76553d3210399 
>   src/test/sh/org/apache/aurora/e2e/http/http_example_bad_healthcheck.aurora 
> 37f2e9c6ebc4a4bbd6089e821420e5a02179c6b9 
> 
> Diff: https://reviews.apache.org/r/41428/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests.
> Changed end to end test.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Reply via email to