-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review110964
-----------------------------------------------------------



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 52)
<https://reviews.apache.org/r/41473/#comment170982>

    Maybe change the name to "custom_executor_config" and the help to "Path to 
custom executor settings configuration file."



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 53)
<https://reviews.apache.org/r/41473/#comment170981>

    Can you add the following constraint annotations:
    
        @Exists
        @CanRead



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 141)
<https://reviews.apache.org/r/41473/#comment170983>

    Is there a reason that 
`o.a.aurora.scheduler.configuration.executor.ExecutorSettingsLoader#ExecutorConfig`
 exists in addition to 
`o.a.aurora.scheduler.configuration.executor.ExecutorConfig`? They seem to be 
identical classes, am I missing something?



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (lines 147 - 148)
<https://reviews.apache.org/r/41473/#comment170985>

    nit: Should fit on one line (but probably will just go away if we de-dupe 
these ExecutorConfig classes).



src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 (line 150)
<https://reviews.apache.org/r/41473/#comment170986>

    Add a message to provide context on the exception? E.g.
    
        throw new IllegalArgumentException("Failed to read executor settings: " 
+ e, e);


- Joshua Cohen


On Dec. 17, 2015, 12:34 a.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 12:34 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Reply via email to