-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/
-----------------------------------------------------------

(Updated Dec. 17, 2015, 8:57 p.m.)


Review request for Aurora.


Changes
-------

Updated code with suggestions and taking into account Bill's patch to remove 
ExecutorConfig dup.


Repository: aurora


Description
-------

Patch to allow Aurora to accept an executor config via commandline which 
overrides the default thermos one.


Diffs (updated)
-----

  .gitattributes a5ab8cf17a14d2527e2a765ff94c3a74e719e0f4 
  NEWS 7a80f32465736de4fbdc7d2c7a3dbf790be31e16 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift 
d765dd798e6861e3920802db00e0b96a250d1bfa 
  api/src/main/thrift/org/apache/aurora/gen/storage.thrift 
624076d1acd8d087a857ebdfeec0831e1bd8e89c 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
ff886d9bc6ef44fa17bbad4fde208ab682483809 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
 d04763418f55aa1e9f1b537987d21920c05fd950 
  
src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoader.java
 fafd90dbb4e628a213a5437aad8a50e7ec64ab79 
  src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
838bfc9ed6242e777d81a17b337f342b7bea72ec 
  src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
3ede9a0c3d1718cab07385c86b774efdfccc29f8 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
9aef59ac5e969b01004d8d9ede825caacca04674 
  src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java 
d8686f1f1b53e5ff2791663489e24c342503831e 
  
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 
0e075607aabdc98a9c8c8c6bfa2929d3428645ff 
  src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java 
258151feda2ea0adf0159c24c0e18a7b78b0c390 
  src/main/python/apache/aurora/client/api/__init__.py 
a6381585a2a9762202f14f929ab922806e84e8b6 
  src/main/python/apache/aurora/client/api/restarter.py 
1983034ff4e7510f7c2ca35ff9c851be24637c8e 
  src/main/python/apache/aurora/client/api/updater_util.py 
b54691eed59854ea5feb4120929cefbf1a95cd24 
  src/main/python/apache/aurora/client/cli/jobs.py 
ccc52c8357650b126185eb6100b3e2e0e37e1d45 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 
6410908b48f54f5188c29f247a9f7797ec802e34 
  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
35a4d627c5049eaec30380699e6005e8da2c10fd 
  
src/test/java/org/apache/aurora/scheduler/configuration/executor/ExecutorSettingsLoaderTest.java
 90986a5b1ed88d3f71fb8414688878aea4a312cc 
  src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
5768481005ef505d6c397101d8cc005af9d6815f 
  src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java 
97647ac3a4e99541484ac14f5796b5dffb01beb0 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java
 02400f0bbf832fdac610868cff665f4312864b8b 
  
src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java
 3a80305e5169c8440b3a9d595fdaf8a52fdd15e3 
  src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java 
0583a63a175880355a7296ebd1c6e6fb5dc99f38 
  src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
f7f5275bed4eda5e276e408bf253f5da6a9cacd8 
  src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java 
PRE-CREATION 
  src/test/python/apache/aurora/client/api/test_api.py 
7debc7967cf926bc09f8a93cafa5059c0657e620 
  src/test/python/apache/aurora/client/api/test_restarter.py 
7557144ef1eed7ef24e69e82d04494c9f58dc217 
  src/test/python/apache/aurora/client/cli/test_restart.py 
2c51d541c4445f287d8794c0117fb038bb776329 
  src/test/python/apache/aurora/client/cli/util.py 
4b5ef4d1137cc9d545ea2205e4d14e438185a990 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 
97ce9732fd9561327c8c4c4f67fefd3866110bcc 
  src/test/python/apache/aurora/common/test_transport.py 
835bb3dfebccd0666f708d0023558aee80c1667d 

Diff: https://reviews.apache.org/r/41473/diff/


Testing (updated)
-------

./build-support/jenkins/build.sh
bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh

Tested with the following config files:
CommandExec.json
```json
{
  "executor": {
    "name": "commandExec",
    "command": {
      "value": "echo 'Hello World from Aurora!'"
    },
    "resources": [
      {
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.25
        }
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        }
      }
    ]
  }
}
```
Thermos.json:
```json
{
  "executor": {
    "name": "thermos",
    "command": {
      "value": "./thermos_executor.pex",
      "arguments": [
        "--announcer-enable",
        "--announcer-ensemble",
        "localhost:2181"
      ],
      "uris": [
        {
          "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
          "executable": true,
          "extract": false,
          "cache": false
        }
      ]
    },
    "resources": [
      {
        "name": "cpus",
        "type": "SCALAR",
        "scalar": {
          "value": 0.25
        }
      },
      {
        "name": "mem",
        "type": "SCALAR",
        "scalar": {
          "value": 128
        }
      }
    ]
  }
}
```


Thanks,

Renan DelValle

Reply via email to