> On Dec. 17, 2015, 1:16 p.m., Bill Farner wrote:
> > LGTM once Joshua's final comments are addressed.

Oh, actually - can you add a line to the NEWS file about the new argument?


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41473/#review111060
-----------------------------------------------------------


On Dec. 17, 2015, 1:10 p.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41473/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2015, 1:10 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Patch to allow Aurora to accept an executor config via commandline which 
> overrides the default thermos one.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  d04763418f55aa1e9f1b537987d21920c05fd950 
> 
> Diff: https://reviews.apache.org/r/41473/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> bash src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> Tested with the following config files:
> CommandExec.json
> ```json
> {
>   "executor": {
>     "name": "commandExec",
>     "command": {
>       "value": "echo 'Hello World from Aurora!'"
>     },
>     "resources": [
>       {
>         "name": "cpus",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 0.25
>         }
>       },
>       {
>         "name": "mem",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 128
>         }
>       }
>     ]
>   }
> }
> ```
> Thermos.json:
> ```json
> {
>   "executor": {
>     "name": "thermos",
>     "command": {
>       "value": "./thermos_executor.pex",
>       "arguments": [
>         "--announcer-enable",
>         "--announcer-ensemble",
>         "localhost:2181"
>       ],
>       "uris": [
>         {
>           "value": "/home/vagrant/aurora/dist/thermos_executor.pex",
>           "executable": true,
>           "extract": false,
>           "cache": false
>         }
>       ]
>     },
>     "resources": [
>       {
>         "name": "cpus",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 0.25
>         }
>       },
>       {
>         "name": "mem",
>         "type": "SCALAR",
>         "scalar": {
>           "value": 128
>         }
>       }
>     ]
>   }
> }
> ```
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Reply via email to