> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 29
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line29>
> >
> >     You are happily mixing the terms jobs and services here. Other sections 
> > of this document also use the word task. It is obvious for us that these 
> > are basically the same thing. However, for people new to Aurora this might 
> > be confusing.

Thanks, reworded.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 35
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line35>
> >
> >     Have you thought about adding an additional section regarding the 
> > aurora config files? Even a simple guideline can be quite helpful for 
> > starters,  like you have one config file per service/job and that these 
> > files are commonly tracked in a git repository.

I see what you mean.  I'd like to avoid a slippery slope wherein this becomes 
encyclopedic, but how about a brief mention and a link to the configuration 
guide? (Added in latest draft.)


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 44
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line44>
> >
> >     I think we should extend this section slightly: 
> >     
> >     * it should somehow contain the word `thermos` as it is used in the 
> > rest of the Aurora documentation quite often
> >     * it could stress a little bit more that this executes the user 
> > processes

Great suggestions, done.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 66
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line66>
> >
> >     A common confusion for Mesos adopters seems to be the relation between 
> > the agent and an executor. We could state here that the agent spaws 
> > executors which in turn runs the user code (either on the physical host or 
> > within a docker container).

Done.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 77
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line77>
> >
> >     When getting started, it is quite difficult to decide whether to 
> > co-locate all those services for simplicity or to keep them seperated for 
> > isolation, security, performance reasons etc. Is there any further advice 
> > we could give here?

Done.


> On Dec. 18, 2015, 2:16 p.m., Stephan Erb wrote:
> > docs/installing.md, line 146
> > <https://reviews.apache.org/r/41564/diff/3/?file=1171347#file1171347line146>
> >
> >     Isn't that outdated?
> 
> John Sirois wrote:
>     I think so - I used `sudo yum install -y mesos-0.23` for this step.

I left this at 0.22.0 because that's what the 0.9.0 rpm currently relies on:

```
Error: Package: aurora-0.9.0-1.el7.centos.aurora.x86_64 (apache-aurora-wfarner)
           Requires: mesos = 0.22.0
```


- Bill


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41564/#review111273
-----------------------------------------------------------


On Dec. 18, 2015, 12:39 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41564/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 12:39 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, John Sirois, and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add a guide for installing Aurora.
> 
> 
> Diffs
> -----
> 
>   README.md e88e1beddbea1be76e6ea6cabee0bd105ae5360e 
>   docs/installing.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41564/diff/
> 
> 
> Testing
> -------
> 
> Rendered here: 
> https://github.com/wfarner/aurora/blob/wfarner/installing_aurora_doc/docs/installing.md
> 
> I could use more eyes and independent trials on the installation steps.
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to