-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41201/#review111929
-----------------------------------------------------------

Ship it!


LGTM! Thanks!

Few minor remaining things.

* Please strip 'docker' from the description and and review request title, as 
it is no longer docker specific
* You should add an entry to the NEWS file in order to announce the new feature.
* If you create an issue in jira and link it here, your change will 
automatically show up in the changelog

- Stephan Erb


On Dec. 27, 2015, 2:44 p.m., Kasisnu Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41201/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 2:44 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Preserve env variables for tasks in docker
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 7b7ef4bde3dfb91010fa6095dea78639d4d0d6e7 
>   src/main/python/apache/aurora/executor/thermos_task_runner.py 
> 25fcca2dddf04ac8764fe99683cb497fb00e6555 
>   src/main/python/apache/thermos/core/process.py 
> 8efdfdcd5b90f8e173b6802b673f43d825d5864f 
>   src/main/python/apache/thermos/core/runner.py 
> 11c06a88cc07cc93cb9c9839f0b086e2558fe73f 
>   src/main/python/apache/thermos/runner/thermos_runner.py 
> a36bd2a9287d9305033a56295996a0849c49d309 
>   src/test/python/apache/aurora/executor/test_thermos_task_runner.py 
> 789d2bf7f2771305254226c3e8697d6e05a11b06 
>   src/test/python/apache/thermos/core/test_process.py 
> 261371d477eeec8898085ec534dcf92876bf5629 
> 
> Diff: https://reviews.apache.org/r/41201/diff/
> 
> 
> Testing
> -------
> 
> Ran ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh with no failures 
> and did manual testing for env variables in containers.
> 
> 
> Thanks,
> 
> Kasisnu Singh
> 
>

Reply via email to