> On Dec. 28, 2015, 4:43 p.m., Zameer Manji wrote:
> > Not sure if you saw but setting classpath to null was the suggested work 
> > around on my post on the gradle forum.
> 
> John Sirois wrote:
>     Ouch - did not.  I played for a good while trying to build up the proper 
> classpath and finally gave up trying to unset-it.
> 
> John Sirois wrote:
>     ... for example, amending the classpath to include 
> sourceSets.main.compileClasspath / sourceSets.test.compileClasspath gets rid 
> of all but 1 src/main and 1 src/test false positive.  Those 2 though are in 
> fact bugs in PMD's UnusedPrivateMethod checker.

OK - read that rec and his suggestion is cleaner, diff coming.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41755/#review112088
-----------------------------------------------------------


On Dec. 28, 2015, 4:15 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41755/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 4:15 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1566
>     https://issues.apache.org/jira/browse/AURORA-1566
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Release notes are here:
>   https://docs.gradle.org/2.10/release-notes
>   https://docs.gradle.org/2.9/release-notes
>   https://docs.gradle.org/2.8/release-notes
> 
> No-op compiles are 20% faster in local testing for example.
> 
> One hack was needed for pmd and a comment was added in `build.gradle`
> calling the shot for future removal.
> 
>  build.gradle                             | 15 +++++++++++++++
>  buildSrc/gradle.properties               |  2 +-
>  gradle/wrapper/gradle-wrapper.properties |  2 +-
>  3 files changed, 17 insertions(+), 2 deletions(-)
> 
> 
> Diffs
> -----
> 
>   build.gradle 6d9d2d4f502c0115aedbddeb46de6b19398b1e89 
>   buildSrc/gradle.properties c7d38905b8fd5e9ec9ef81732f5b350fd56a998b 
>   gradle/wrapper/gradle-wrapper.properties 
> 7eedd255dcda47350c645701ed2fc25d6b53ab96 
> 
> Diff: https://reviews.apache.org/r/41755/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to