-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41762/#review112116
-----------------------------------------------------------



commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
 
<https://reviews.apache.org/r/41762/#comment172444>

    Background - `NIOServerCnxn.Factory` extended `Thread`, 
`NIOServerCnxnFactory` is a `Runnable`, so we no longer have `isAlive()`.  The 
Thread is still there, but privately managed.  If we want to maintain this 
precondition and the gate below, we could do our own state tracking.  However, 
i'm not sure it's worth it.


- Bill Farner


On Dec. 28, 2015, 7:07 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41762/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 7:07 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Primary motivation here is to get past 3.4.0, which changed how logging works 
> in ZK (primarily via slf4j).  This will make it easier to have a cohesive 
> logging story.
> 
> There was some fallout - I did not update to latest - 3.4.7.  I encountered 
> issues with a kerberos-related test (see comment in `build.gradle`) with 
> >=3.4.3.  I spent a few minutes looking for a solution, but decided to stop 
> short so as to return to the work i was really trying to tackle.
> 
> 
> Diffs
> -----
> 
>   build.gradle d32aea5e4c888cb215af7bedd5e9c1a8f41308c8 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  03d47c37f67dee64eca2107ab1510c7efcdd0931 
> 
> Diff: https://reviews.apache.org/r/41762/diff/
> 
> 
> Testing
> -------
> 
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to