> On Dec. 28, 2015, 8:12 p.m., Bill Farner wrote:
> >

I found that by upgrading all the way to 3.4.7 the krb issues go away in the 
unit tests (`./gradlew -Pq build`), although e2e krb fails (digging).  
Presuming I can find a fix for that (we'll need to upgrade someday) you get a 
natural state tracking variable back by using a nullable zooKeeperServer since 
in 3.4.7 you cannot re-use the server after a shutdown (see failure trace 
below), so you can just null it out in `shutdownNetwork` and (re)create it in 
`startNetwork`.
```
java.lang.IllegalThreadStateException
        at java.lang.Thread.start(Thread.java:705)
        at 
org.apache.zookeeper.server.ZooKeeperServer.startSessionTracker(ZooKeeperServer.java:455)
        at 
org.apache.zookeeper.server.ZooKeeperServer.startup(ZooKeeperServer.java:413)
        at 
org.apache.zookeeper.server.NIOServerCnxnFactory.startup(NIOServerCnxnFactory.java:119)
        at 
org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.startNetwork(ZooKeeperTestServer.java:90)
        at 
org.apache.aurora.common.zookeeper.testing.ZooKeeperTestServer.restartNetwork(ZooKeeperTestServer.java:111)
        at 
org.apache.aurora.common.zookeeper.testing.BaseZooKeeperTest.restartNetwork(BaseZooKeeperTest.java:71)
        at 
org.apache.aurora.common.zookeeper.GroupTest.testJoinsAndWatchesSurviveDisconnect(GroupTest.java:154)
```


> On Dec. 28, 2015, 8:12 p.m., Bill Farner wrote:
> > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java,
> >  line 105
> > <https://reviews.apache.org/r/41762/diff/1/?file=1177135#file1177135line105>
> >
> >     Background - `NIOServerCnxn.Factory` extended `Thread`, 
> > `NIOServerCnxnFactory` is a `Runnable`, so we no longer have `isAlive()`.  
> > The Thread is still there, but privately managed.  If we want to maintain 
> > this precondition and the gate below, we could do our own state tracking.  
> > However, i'm not sure it's worth it.

Its easy enough to just null out the existing connectionFactory after shutdown 
and use its null status as the check, but I'm not tied to this - I just noticed 
when digging a bit on krb as noted above.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41762/#review112116
-----------------------------------------------------------


On Dec. 28, 2015, 8:07 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41762/
> -----------------------------------------------------------
> 
> (Updated Dec. 28, 2015, 8:07 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Primary motivation here is to get past 3.4.0, which changed how logging works 
> in ZK (primarily via slf4j).  This will make it easier to have a cohesive 
> logging story.
> 
> There was some fallout - I did not update to latest - 3.4.7.  I encountered 
> issues with a kerberos-related test (see comment in `build.gradle`) with 
> >=3.4.3.  I spent a few minutes looking for a solution, but decided to stop 
> short so as to return to the work i was really trying to tackle.
> 
> 
> Diffs
> -----
> 
>   build.gradle d32aea5e4c888cb215af7bedd5e9c1a8f41308c8 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  03d47c37f67dee64eca2107ab1510c7efcdd0931 
> 
> Diff: https://reviews.apache.org/r/41762/diff/
> 
> 
> Testing
> -------
> 
> end-to-end tests
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to