-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41778/#review112226
-----------------------------------------------------------


Thanks for the quick feedback.  Sounds like there's enough momentum for me to 
flesh out the patch more.  Please hold ship-its until i have a more substantial 
version of the patch.

- Bill Farner


On Dec. 29, 2015, 1:39 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41778/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 1:39 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I'm using this file as a proposed convention for test targets in `BUILD` 
> files.  In addition to being less redundant, i find the resulting file much 
> easier to understand.  In the past when refactoring, i can find it 
> nightmarish to go back and bring all the build targets back into line (often 
> repeating myself with imports changed in code).
> 
> If this proposal is accepted, i would like to further propose we collapse our 
> `BUILD` files into one target for all python tests.
> 
> Note that this patch is related to 
> https://issues.apache.org/jira/browse/AURORA-959
> 
> 
> Diffs
> -----
> 
>   src/test/python/apache/aurora/client/api/BUILD 
> 2a55cec51324c18debf10a1da93a74043f288a93 
> 
> Diff: https://reviews.apache.org/r/41778/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to