----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41777/#review112218 -----------------------------------------------------------
Ship it! LGTM mod the 2 similar issues marked, the rest is small stuff. commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java (line 356) <https://reviews.apache.org/r/41777/#comment172563> This branch is a perf-change since the message is now always built, but this seems inconsequential / just fine. commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java (line 58) <https://reviews.apache.org/r/41777/#comment172564> Unused - can kill. src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java (line 125) <https://reviews.apache.org/r/41777/#comment172568> You have kept the status quo - but the status quo is weird! The check is for debug and the log is at info. As you see fit, but if the semantics are actually what is wanted a comment is in order; otherwise, take advantage of the built-in lazy Logger message formatting here. src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java (line 260) <https://reviews.apache.org/r/41777/#comment172569> Kill the guard and convert to lazy-format. src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java <https://reviews.apache.org/r/41777/#comment172570> The only use of inject jul Logger I can remember ever coming across outside guice docs. src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (line 186) <https://reviews.apache.org/r/41777/#comment172571> Kill guard, use free lazy formatting. src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java (line 205) <https://reviews.apache.org/r/41777/#comment172572> s/infoLevel/debugLevel/ src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java (line 119) <https://reviews.apache.org/r/41777/#comment172573> Leverage lazy format and kill guard. src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java (line 93) <https://reviews.apache.org/r/41777/#comment172585> Extra work now for those with >=WARN, but I imagine negligible. src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java (line 98) <https://reviews.apache.org/r/41777/#comment172586> This now always logs all the fast queries - I don't think you want this! src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java (line 206) <https://reviews.apache.org/r/41777/#comment172582> Kill guard, use {} lazy formatting. src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java (line 136) <https://reviews.apache.org/r/41777/#comment172584> Extra work now for those with >=WARN, but I imagine negligible. src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java (line 141) <https://reviews.apache.org/r/41777/#comment172587> This now always logs all the fast queries! src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java (line 201) <https://reviews.apache.org/r/41777/#comment172583> Hrm, well this adds more work to removing debug guards, but I do think its worth it to remove prod clutter. - John Sirois On Dec. 29, 2015, 2:08 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41777/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 2:08 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > slf4j allows us to isolate the decision and configuration of our logging > backend. > > Apologies for the monster patch. Most of this is pretty mechanical (and was > automated), however. > > > Diffs > ----- > > > commons-args/src/main/java/org/apache/aurora/common/args/apt/Configuration.java > 3ff3474dc3c8536758a0a0b3e05587daa7cde3eb > commons/src/main/java/org/apache/aurora/common/application/Lifecycle.java > a71a51d2fa9465926df5b1232f450767df150847 > > commons/src/main/java/org/apache/aurora/common/application/ShutdownRegistry.java > b440e7e6a2b26533d0ce52bf0ffb21735ef6352f > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java > c98ed8750cf8306593587f28bf8f3e76a01b6254 > commons/src/main/java/org/apache/aurora/common/args/Args.java > db8e1694a81a5791d13f8d5c6cfa5f489209e82f > commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java > ddffdf9c8d41166fee49866a3b7fbc2efd6bbe54 > commons/src/main/java/org/apache/aurora/common/args/parsers/ListParser.java > 676f88be9a8f9d3f743ee9e62f133470cb84df6b > commons/src/main/java/org/apache/aurora/common/args/parsers/SetParser.java > 75031f49c7a509f55edc0f7d624dfcc7a0bd2930 > commons/src/main/java/org/apache/aurora/common/collections/Iterables2.java > 7ae80ce7193717fd82dc59a346d07cba0d10e4cb > commons/src/main/java/org/apache/aurora/common/inject/TimedInterceptor.java > 684e7bb885fcd142e926b4e68c25323e465624fb > > commons/src/main/java/org/apache/aurora/common/net/InetSocketAddressHelper.java > b3719d8f71679f7165631fd6cd4f18a93d5f871a > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/AbortHandler.java > 42e668d09e52bdeb50a05ee7000b7f51e3160104 > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParams.java > c09be674d65010dfbc73fe09d8051558d236001c > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/LogConfig.java > c3fd80863e66f50023647c25e47e4406e89a7fa9 > > commons/src/main/java/org/apache/aurora/common/net/http/handlers/QuitHandler.java > 40872e2778b9f3cb05e58be22a1ad4e31b3e1b3e > commons/src/main/java/org/apache/aurora/common/stats/JvmStats.java > d1b072d14556be00bf2b6e06019b696c7c3235e3 > commons/src/main/java/org/apache/aurora/common/stats/Percentile.java > d8046b635b1ac5d816457430fb75ea17a6f46fde > commons/src/main/java/org/apache/aurora/common/stats/Rate.java > dbb90c45fed4ba2c7b97c6e14646345f6fc430f7 > commons/src/main/java/org/apache/aurora/common/stats/RequestStats.java > 5467810e3ac546b007ae8436ffe8c8dce9231eef > commons/src/main/java/org/apache/aurora/common/stats/SlidingStats.java > 334167275bdbd4f494b8e89c3b2575c21946a29e > commons/src/main/java/org/apache/aurora/common/stats/Stats.java > d4b6a3133c5ece40a398d8cfe605627d2344f0a8 > commons/src/main/java/org/apache/aurora/common/stats/TimeSeries.java > 45f604c76ea255de3c805a6a48406bcd3e587838 > > commons/src/main/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImpl.java > 6b237fbf7d308150c8dd12f7e25e2bd6aca900ab > commons/src/main/java/org/apache/aurora/common/util/BackoffHelper.java > b251e9b84aa33c7c1e1366aaf8872a367864e408 > commons/src/main/java/org/apache/aurora/common/util/BuildInfo.java > 4f9c3847bc64c80e64bd3c04ea8df3ae44716947 > commons/src/main/java/org/apache/aurora/common/util/StateMachine.java > dbaaadde9aa821e2293656bd48afc47816e900a2 > > commons/src/main/java/org/apache/aurora/common/util/TruncatedBinaryBackoff.java > fd74b9f37c6cc24c7ea1cb239ba6354661d931e2 > > commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java > 2756af49c7702ac1343712476e138fd4367aa756 > commons/src/main/java/org/apache/aurora/common/util/testing/FakeClock.java > 2ed8b15686e0bfc6310c0427e3501e9f6d5d8af7 > commons/src/main/java/org/apache/aurora/common/zookeeper/Candidate.java > f679d92e6ede869e5b374c80b261ba7e83858152 > commons/src/main/java/org/apache/aurora/common/zookeeper/CandidateImpl.java > bb0a48d3d8e55fd95b07bc7a0999aa6a3d2fe691 > commons/src/main/java/org/apache/aurora/common/zookeeper/Group.java > d3681700e7f993da711f3b1ac87dc0335075cf71 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSet.java > cfeac921fcc70917a6b252e6637ee8e12f1fc3c1 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > 6a0a314ffc27e73024ac8ac7c9e3a7ba83567c3a > > commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java > 231aa911693134213b60e477ad12fbebe3c69da6 > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperClient.java > e399d38a8600f43439a819d0a225477a62eb2285 > > commons/src/main/java/org/apache/aurora/common/zookeeper/ZooKeeperUtils.java > a8dcfa1132178fa15774426b8430ff8e13a7a730 > commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java > 48afb6113daf4bc203fcc51de6fc074180630085 > commons/src/test/java/org/apache/aurora/common/args/ArgsTest.java > b64dcab223be4e4daed97cebc1a04fc3e1ee6690 > commons/src/test/java/org/apache/aurora/common/args/OptionInfoTest.java > 0fe0aeb40411dbaaeaa1845e44b054d614ee1604 > commons/src/test/java/org/apache/aurora/common/args/ParsersTest.java > 75d3c44ba44d82d5226e3d36c9930d73691b752c > > commons/src/test/java/org/apache/aurora/common/collections/Iterables2Test.java > 11ff3764169a1f0d37e09adaca4da3227a25a707 > > commons/src/test/java/org/apache/aurora/common/net/InetSocketAddressHelperTest.java > c2dfe16e8ddc43de7a5be766035805318cd02e15 > > commons/src/test/java/org/apache/aurora/common/net/http/handlers/HttpServletRequestParamsTest.java > b7812acb86281ecf07763326b6a2299c27f648ba > > commons/src/test/java/org/apache/aurora/common/net/http/handlers/StatSupplierTestBase.java > 3f9444dfcf9865b560a8ea2a24b4d4690821a688 > > commons/src/test/java/org/apache/aurora/common/net/http/handlers/TimeSeriesDataSourceTest.java > 86de2cc5bad14a1f0b844f370cad9eedafc3b8af > commons/src/test/java/org/apache/aurora/common/stats/PercentileTest.java > 63c9f0fe1f8fbdbba3229eead4572a149a76df5d > commons/src/test/java/org/apache/aurora/common/stats/RateTest.java > 46081a007350745d88ea8eb3919b43405af63afd > > commons/src/test/java/org/apache/aurora/common/stats/TimeSeriesRepositoryImplTest.java > 6112e7caab8c0fd15f773624252e207b373ff436 > > commons/src/test/java/org/apache/aurora/common/testing/easymock/EasyMockTestTest.java > 35dde9e9b0d69612af6466907f7ed44ed859fbce > commons/src/test/java/org/apache/aurora/common/util/BackoffHelperTest.java > 78ba8fe7e0640b7c4b04b78384e15a33e1b81b2f > commons/src/test/java/org/apache/aurora/common/util/SamplerTest.java > e714121ad91cdf298ad8f9f4720b66d3f0cb2697 > > commons/src/test/java/org/apache/aurora/common/util/templating/StringTemplateHelperTest.java > fa2feb80c0e82ba18e733b344f94d5e8c148647c > > commons/src/test/java/org/apache/aurora/common/util/testing/FakeClockTest.java > 30fa86f191202b715c98fdd6e423c1b7e822fa7b > commons/src/test/java/org/apache/aurora/common/zookeeper/GroupTest.java > 729e7ae37a4d270fc646a45471abc589aadb84bd > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 69749edada07d8f90ce31fb6a56fa37a53a00961 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetsTest.java > d3cca3f6f3af0fa17a5186c5d90f38373afc7f17 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperClientTest.java > 61a94b5286a5084ff5c3c44cf9022d8235403dad > > commons/src/test/java/org/apache/aurora/common/zookeeper/ZooKeeperUtilsTest.java > b17fe93534c756b9ab9ed9bdbc8ec11ea3003c2d > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > 4e29e904010f51f2ef35fff0ddd72a7b9a84926a > src/main/java/org/apache/aurora/GuavaUtils.java > 5cdd9a92022ecd29bc89a4054becb46faa8c4ced > src/main/java/org/apache/aurora/GuiceUtils.java > bc99a3a1e5059435d9fff8c59ee2f90e16beebaf > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 0db1ebc58bd7ce8346de1e51d4ce7b03c6a677a3 > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > e19bb2748fb1c096f924202d6c3f50359ba4d509 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > fb1696ac526713a147d96425bc38854fdb35aedc > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > a2034ffcb4ed08f5262ced4bf1394657687cb006 > src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java > 1e820bd9586e6841ed48c1f0fee24347d5ed8e0d > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 8243098a8fcdc7f6d4306f00b761e82f6c5812c3 > src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java > 28aad86b27b09c8b72c7a92cf5568d5493b4ff47 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 3822d6e734e232bbb194e749f0cfa1f8fc4ebcf9 > src/main/java/org/apache/aurora/scheduler/app/ServiceDiscoveryModule.java > 078042bbe3d4df95f7d380dbcee45912778c7b5b > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > 848cb542ca2fcd1fc0ec8ac45d8987be5ed9173f > src/main/java/org/apache/aurora/scheduler/base/AsyncUtil.java > d6d135022fd26bfcd2f799f08375428b95f3bf4f > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > 91171b1e8bf1eabe0fe3294dd0e8565f486c6ca5 > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > a33f63ad0dace29da26b3b39728819ab637ca813 > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java > f80391341ac4e86aa1fdc58a751c7ab98c55f13f > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java > dba47eb64c03f8458a344bfeafa5e73f06b2468b > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > 264537180da91f59173301bf20b549ea01c0d5cb > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java > 016fee177320a29b7d777ca8e6968e996418a7a3 > src/main/java/org/apache/aurora/scheduler/events/PubsubEventModule.java > e9e020693058d76f5254bdb9d2a56d7bcbd9a899 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > 625adcbda95f1d9e618afbd39dbe86be89dac61e > src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java > b5eed69741cc02f57ae8ceefd08c24f37226a162 > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 277858b8d5508151a18e0fac9a5d7dbdf38d2080 > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > 7c3c7e5b0c0b6fb2a857384f9e1ee8ed975d0818 > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirectFilter.java > b83166eb29665b39aca8b3961ffb5a6c7a0561ce > src/main/java/org/apache/aurora/scheduler/http/QuitCallback.java > 10a9bc86852e04c0c9f2be815f62ef3e309e0761 > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java > b889f9354228833ffd486c951957161d5da737c2 > > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java > 579d27aef3f186c26bb9e35395cf30c31f292e2d > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingInterceptor.java > 68df95a132db094f67de58ea3a6f21b38431fd5d > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroKerberosAuthenticationFilter.java > a18903ee65ac291fb62b442b1fc44e251fd00242 > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLog.java > cb89be2cc966afecc4c11fb70aa9e06a74264ebb > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java > 5c6f6a474ad11a5e95e4d1913aee267dbefc3ecc > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > 469108a487adb3690148c2ec1ddf511d686c2f2f > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > 9ca538150975839d8716efe6d476c405099f9d67 > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverModule.java > acf48cf8c4e221adb3696f3b8d8493c127091007 > src/main/java/org/apache/aurora/scheduler/mesos/SchedulerDriverService.java > 1b1443d69821519ea93d9680913448ee44857c4b > src/main/java/org/apache/aurora/scheduler/mesos/TaskStatusStats.java > 53a94bf5b4122370e1aac8993710c920a90bd79a > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > aa224737dd8f9e901035b2b608c3e91e953aebb8 > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java > fbc589e9a7592cce6d92c4e987cde2e056406c3a > > src/main/java/org/apache/aurora/scheduler/offers/RandomJitterReturnDelay.java > 883e419d02ad702309ce302b748f71a2f30504dd > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > d1087424b63ea2e15601f58e97e969395b04c0fa > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > fa4e3e883b56074106fcd1f45015cbfb115ad76e > src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java > 9bf7b2eda98aa2685f79d5dcfc1790e11faaffe7 > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > d1108a3dd329a4a09e67dcec62e06c0ab308a124 > src/main/java/org/apache/aurora/scheduler/reconciliation/KillRetry.java > 119ef71ab2993f1ac74bab25bec3ec5cd4a67896 > > src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java > 7dae70c4c9cb2efbf66e1d269f96676ff450eeaf > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskTimeout.java > 7c09f7cc49a0684c54947a3c92e30c4e013874ea > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > 291bf5f0baefef6dd10d19ec89e173ce495e6380 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > 7930c6c2edddfbec5bacc4179e16341de3c4ee57 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 575ae1d0b3f31391085f564c6e7c345c6a9dbae2 > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > 60ebfdfd77af8775c93098f1cde49f81308d13ca > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > 6503af2cd2c2f97403f06d1134474cf913870203 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 50868eadf87b213ec86399227a18aee9bf68a971 > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java > b8d8bf9814fa5532d9ba2bfb0c73250425d7973d > src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java > c1e7197d663f94f7382085f4ead3a3386b1cb17f > src/main/java/org/apache/aurora/scheduler/storage/StorageBackfill.java > 5401a28816e7bab71b4650f4e31cfe45981d1191 > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java > 5b9e9eee4d8abfdb421cf9e63272553818c2c6ea > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java > 2cd87936b9fc5aef5069b7d0da0e4c58747f7a82 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > 59ba72592929d081570d020b5c6e9be4a15ca94d > src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java > 3a2a04983c5862fb35ad7c3997e98ce09fe01e5f > > src/main/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollector.java > 9ef377aacc087d5ff7d23b15814f59618eaa2b63 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java > ce5b1f4e870a3cf743429e6789e74184ff410bbc > src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java > 48a01f14fe1a73b576d366304e623409aaf5ec08 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > b2021b8d75412cccd175b4ecce63b638cc0454b8 > src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java > 548b5e7538c8d4914476b87cd123f0f22899ec2b > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 6928cc8235a2b9a2fa16ac140676ec51fe95d894 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java > de144133d870a657bb173ff8e45c1b25c787a83d > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > 3077c3756d550bd5fbcd7bf9db1726c5adceadd6 > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java > 6eea13288f0c195562c515d57035173fc4724ada > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java > b252468c99a1e2f4b92c4a1d4ce02330d3f7b80c > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 2d34f3694a1e47dc4fc15b65f2ae66a1b15abbb4 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 93f6efb56a3b4560f946c1ca02521b4148244ebb > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 0afe9246ba1e9dbfb9c542af24b0da72bcd8b2e1 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > 10e0a5a4e6016021ad3eb445610c1471ca99fd66 > > src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java > 35c68f179341733f39887df4b5defdf5f72188df > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java > 3a2eec3726703e5894181c95e276c1b2e95bf9d3 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > ca4640028d47784adfa499eac96b0e18a7acb3ed > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java > 4e8ad879ab46d2a8bf696e88d61882cbbb3270f8 > src/main/java/org/apache/aurora/scheduler/updater/OneWayJobUpdater.java > 72ccfa8c39dfffdb83779920d7a69dcecb38f453 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > d53ec6a4762fef838cd7e3d4a0a11123c22e0232 > src/test/java/org/apache/aurora/scheduler/app/local/FakeMaster.java > 6b1d2b160aee56c135105d009ea36c2e39d1d491 > src/test/java/org/apache/aurora/scheduler/base/AsyncUtilTest.java > 876110694f9d0181b79e9f8341712006f4658856 > src/test/java/org/apache/aurora/scheduler/events/PubsubEventModuleTest.java > 4709b776c1cca9914c003668a1cffb7ea8b3970f > src/test/java/org/apache/aurora/scheduler/http/ServletFilterTest.java > 4057e7cb70fb9005296b727a42ab94efcf136c68 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > 6dffd77da01643b1fbc36a12f3f1d0e9adefc9b7 > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java > 0d9628cf071b57ca367aa29ce64a5a1b71e94c82 > > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java > d09178a4e145266c8ac5bbe32290fd48eb5d4bcd > > Diff: https://reviews.apache.org/r/41777/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
