-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41785/
-----------------------------------------------------------

(Updated Dec. 29, 2015, 10:29 p.m.)


Review request for Aurora, John Sirois and Zameer Manji.


Changes
-------

Changed to use log4j.


Summary (updated)
-----------------

Remove scheduler log scaffolding


Repository: aurora


Description (updated)
-------

Using log4j as a straw man.  If we decide to choose logback instead, i'm happy 
to update this patch.

Here's an example of the log format:
```
I1229 22:16:54.568 [pool-10-thread-1, FakeMaster:139] All offers consumed, 
suppressing offer cycle.
```
As opposed to what's on master:
```
I1230 06:26:14.987 THREAD143 
org.apache.aurora.scheduler.app.local.FakeMaster.lambda$start$0: All offers 
consumed, suppressing offer cycle.
```

I could more closely match the existing format, but i think the change is an 
improvement.

TODO before submitting: Update `LogConfig` to align with the selected backend.  
I'll wait until we decide on a backend before i update this.


Diffs (updated)
-----

  NEWS 394b31cf1c863c54b89e7f27ab3694bdd51b2eeb 
  build.gradle 5ff10d90fa8f748b066faf1c4ec385b22dd883b4 
  commons/src/main/java/org/apache/aurora/common/logging/Glog.java 
5bae399cd9360a0093c67c608cf68b013a709194 
  commons/src/main/java/org/apache/aurora/common/logging/LogFormatter.java 
0cb621da2b2f286d9eda9eb18ecac087208d7b6b 
  commons/src/main/java/org/apache/aurora/common/logging/RootLogConfig.java 
26dd0aa5682faf31ba4cc086d32bf61557ef1fde 
  commons/src/main/java/org/apache/aurora/common/logging/log4j/GlogLayout.java 
1a90ded72c81a7e3fdc9dab515a2622c55563e6a 
  commons/src/test/java/org/apache/aurora/common/logging/LogFormatterTest.java 
9f041915c7fd4513a6255b05b3d0096779b5f1b3 
  commons/src/test/java/org/apache/aurora/common/logging/RootLogConfigTest.java 
9d55a1aaf555d6e25ad97622612fad61271d0e25 
  examples/vagrant/upstart/aurora-scheduler-kerberos.conf 
4f43892723db4744db205ea7dd107e9e9ce9d5db 
  examples/vagrant/upstart/aurora-scheduler.conf 
4033184451f36cb5f0233ea96e3dceaae6741275 
  src/main/java/org/apache/aurora/scheduler/app/Log4jConfigurator.java 
28aad86b27b09c8b72c7a92cf5568d5493b4ff47 
  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
3822d6e734e232bbb194e749f0cfa1f8fc4ebcf9 
  src/main/resources/log4j2.xml PRE-CREATION 

Diff: https://reviews.apache.org/r/41785/diff/


Testing
-------

end-to-end tests are green


Thanks,

Bill Farner

Reply via email to