-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41812/#review112356
-----------------------------------------------------------



build-support/jenkins/review_feedback.py (line 133)
<https://reviews.apache.org/r/41812/#comment172830>

    Rushed this one - 'RB#%d' is no longer correct.
    Another xix RB coming.


- John Sirois


On Dec. 30, 2015, 4:33 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41812/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2015, 4:33 p.m.)
> 
> 
> Review request for Aurora and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The error message generation was itself failing.  The depends_on field
> looks like so:
> ```
> "depends_on": [
>  {
>    "href": "https://reviews.apache.org/api/review-requests/41762/";,
>    "method": "GET",
>    "title": "Upgrade ZooKeeper dep to 3.4.2"
>  },
>  {
>    "href": "https://reviews.apache.org/api/review-requests/41777/";,
>    "method": "GET",
>    "title": "Use slf4j throughout the scheduler."
>  }
> ],
> ```
> 
> This change just uses href since thats more directly useful to the reader
> than the RB id number.
> 
>  build-support/jenkins/review_feedback.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/review_feedback.py 
> aa2c836ad453a52bac29020a3be2c4f614b0ee8a 
> 
> Diff: https://reviews.apache.org/r/41812/diff/
> 
> 
> Testing
> -------
> 
> Manual curling of the api to check the schema for this correction.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to