----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41762/#review112361 -----------------------------------------------------------
Ship it! Ship It! - Zameer Manji On Dec. 29, 2015, 9:09 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41762/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 9:09 a.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > Primary motivation here is to get past 3.4.0, which changed how logging works > in ZK (primarily via slf4j). This will make it easier to have a cohesive > logging story. > > There was some fallout - I did not update to latest - 3.4.7. I encountered > issues with a kerberos-related test (see comment in `build.gradle`) with > >=3.4.3. I spent a few minutes looking for a solution, but decided to stop > short so as to return to the work i was really trying to tackle. > > > Diffs > ----- > > build.gradle 5ff10d90fa8f748b066faf1c4ec385b22dd883b4 > > commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java > 03d47c37f67dee64eca2107ab1510c7efcdd0931 > > Diff: https://reviews.apache.org/r/41762/diff/ > > > Testing > ------- > > end-to-end tests > > > Thanks, > > Bill Farner > >
