----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41894/ -----------------------------------------------------------
Review request for Aurora and Bill Farner. Repository: aurora Description ------- With the upgrade to 3.4.2 and the switch from `NIOServerCnxn.Factory` to `NIOServerCnxnFactory` came a change in the server internals. Calling `connectionFactory.startup(zooKeeperServer)` now eventually calls `ZooKeeperServer.startup` which calls `SessionTrackerImpl.start`. This last is a problem since `SessionTrackerImpl` is a `Thread` and so throws `IllegalThreadStateException`. commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) Diffs ----- commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java 54b0a09355c1467362c2ad788e217dd5f52de522 Diff: https://reviews.apache.org/r/41894/diff/ Testing ------- Not green locally due to ZK/krb interaction issues from https://git1-us-west.apache.org/repos/asf/aurora/repo?p=aurora.git;a=commit;h=8706a781968912c68688284d9d3813d34ce45bf7, but the CI script gets further on my machine with this fix. Thanks, John Sirois
