----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42042/#review113489 -----------------------------------------------------------
Just notes, waiting on the discussion thread to settle as you are. src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java (line 85) <https://reviews.apache.org/r/42042/#comment174229> This is a simpler scheme for handling generic parsers than the ParserOracle in commons args - I like it. src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java (line 152) <https://reviews.apache.org/r/42042/#comment174230> com.google.common.reflect.Reflection#newProxy is slightly simpler to use here. src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java (line 162) <https://reviews.apache.org/r/42042/#comment174233> OK - this took a while to grok, my head was still back in code-genning a backing bean for the interface where this is quite a bit more straightforward! This will warrant a code comment if implementation proceeds; ie: invoking a default method is _barely_ doable if you have java 7+. - John Sirois On Jan. 7, 2016, 6:17 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42042/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 6:17 p.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > ------- > > This is purely at PoC phase, mostly to serve as an exmaple for a discussion > email. Not yet to be submitted. > > > Diffs > ----- > > build.gradle 6d7af5e020afa58040e616caa1911ac69955f0bf > > src/main/java/org/apache/aurora/scheduler/app/params/CommandLineParameters.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/app/params/parsers/GuavaOptionalParser.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/app/params/parsers/ListParser.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/params/parsers/MapParser.java > PRE-CREATION > > src/main/java/org/apache/aurora/scheduler/app/params/parsers/OptionalParser.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parser.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/params/parsers/Parsers.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/app/params/parsers/SetParser.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/app/params/CommandLineParametersTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/42042/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
