-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42041/#review113622
-----------------------------------------------------------

Ship it!


Ship It!

- John Sirois


On Jan. 8, 2016, 2:52 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42041/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 2:52 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> With this enabled operators can visit the H2 console at /h2console and run 
> queries like `SELECT * FROM INFORMATION_SCHEMA.QUERY_STATISTICS ORDER BY 
> MAX_EXECUTION_TIME DESC;` to diagnose slow schedulers.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> e3efbdb80d8b18312bf1589eef883cdeee65b225 
> 
> Diff: https://reviews.apache.org/r/42041/diff/
> 
> 
> Testing
> -------
> 
> Ran `SELECT * FROM INFORMATION_SCHEMA.QUERY_STATISTICS ORDER BY 
> MAX_EXECUTION_TIME DESC;` within vagrant and saw query statistics.
> 
> Benchmarks
> 
> Master (c595228):
> Benchmark                                                                     
> (numPendingTasks)   Mode  Cnt      Score      Error  Units
> SchedulingBenchmarks.ClusterFullUtilizationBenchmark.runBenchmark             
>               N/A  thrpt   10  64138.084 ± 6732.130  ops/s
> SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark    
>               N/A  thrpt   10  23863.861 ± 2101.622  ops/s
> SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark  
>               N/A  thrpt   10   2228.883 ±  311.434  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>                 1  thrpt   10     50.914 ±    2.488  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>                10  thrpt   10     43.729 ±    3.038  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>               100  thrpt   10     44.409 ±    4.426  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>              1000  thrpt   10     40.429 ±    7.526  ops/s
> SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark  
>               N/A  thrpt   10  22942.538 ± 1281.331  ops/s
> 
> 
> This change:
> Benchmark                                                                     
> (numPendingTasks)   Mode  Cnt      Score      Error  Units
> SchedulingBenchmarks.ClusterFullUtilizationBenchmark.runBenchmark             
>               N/A  thrpt   10  65285.628 ± 2422.816  ops/s
> SchedulingBenchmarks.InsufficientResourcesSchedulingBenchmark.runBenchmark    
>               N/A  thrpt   10  24573.332 ± 1332.474  ops/s
> SchedulingBenchmarks.LimitConstraintMismatchSchedulingBenchmark.runBenchmark  
>               N/A  thrpt   10   2430.402 ±  258.860  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>                 1  thrpt   10     43.810 ±    2.669  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>                10  thrpt   10     37.378 ±   14.637  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>               100  thrpt   10     40.180 ±    9.738  ops/s
> SchedulingBenchmarks.PreemptorSlotSearchBenchmark.runBenchmark                
>              1000  thrpt   10     24.130 ±   15.746  ops/s
> SchedulingBenchmarks.ValueConstraintMismatchSchedulingBenchmark.runBenchmark  
>               N/A  thrpt   10  18429.830 ± 3077.426  ops/s
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to