-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42125/
-----------------------------------------------------------

Review request for Aurora, Maxim Khutornenko and Bill Farner.


Summary (updated)
-----------------

New interface to allocate resources of multiple roles from offer


Bugs: AURORA-1109
    https://issues.apache.org/jira/browse/AURORA-1109


Repository: aurora


Description (updated)
-------

This review is a prototype for introducing multiple role support in Aurora.
This creates a new interface OfferAllocation (with implementation), which 
allcoates resources to resources field in TaskInfo and ExecutorInfo from an 
offer.

Current implementation prefers reserved resources over shared resources ('*' 
role) if both are present. This can be  customized with a differnet comparator 
from PREFER_RESERVED in the future when needed.

Several caveats:
1. This performs the allocate after scheduling decision in 
TaskAssigner.maybeAssign is done, which leaves possibility of inconsistency and 
late failure;
2. Old code used to construct resources has not been cleaned up yet;
3. OfferAllocationImpl's constructor allows to throw, which is a bit awkward.


Diffs
-----


Diff: https://reviews.apache.org/r/42125/diff/


Testing (updated)
-------

Only testing with new and existing unit test. I'll work on more integration 
test once we decide that this is the proper direction.


Thanks,

Zhitao Li

Reply via email to