----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42225/#review114108 -----------------------------------------------------------
Ship it! I almost always use -sS for this very reason - this makes sense to me! build-support/thrift/Makefile (line 50) <https://reviews.apache.org/r/42225/#comment174913> >100 but I'm not sure how this goes in non-py|java files for aurora. - John Sirois On Jan. 12, 2016, 4:51 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42225/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 4:51 p.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > ------- > > From the curl documentation: > ```` > -S, --show-error > > When used with -s it makes curl show an error message if it fails. > ```` > > It's possible for curl to fail when grabbing the tarball or patch and this > will > show users why it failed. > > > Diffs > ----- > > build-support/thrift/Makefile 8b1da2a01b9ecc1832d4e56bfaacb5b40cdbbab0 > > Diff: https://reviews.apache.org/r/42225/diff/ > > > Testing > ------- > > Ran `make` in the `build-support/thrift` directory. > > > Thanks, > > Zameer Manji > >