----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114795 -----------------------------------------------------------
src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java (line 152) <https://reviews.apache.org/r/42332/#comment175644> You could centralize this handling in deleteTasks - it has all the ids to give as useful a message as you have here, and that localizes the otherwise overly broad looking RTE catch. It'll clean up the temp you had to introduce below as well. Further, it'll give you 1 nice spot to add a comment explaining why termination on 1 failed prune is sane; ie: you can point out the inevitable history growth issue and that rolling back is better than waiting for the failure and then rolling back. - John Sirois On Jan. 14, 2016, 5:53 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42332/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2016, 5:53 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository: aurora > > > Description > ------- > > Task pruning is critical to the operation of a large cluster. Failure to > prune tasks can lead to storage growing in unexpected ways leading to > scheduling slowdown. This patch adds shutdown on task pruning failure to > prevent the scheduler from entering an undefined state. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > 2064089937f5178b1413d386a312f4173a0e35fb > > src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java > 295960f13693c6ba0d7075a8ef7f9680a91ae69d > > Diff: https://reviews.apache.org/r/42332/diff/ > > > Testing > ------- > > ./gradlew build -Pq > > > Thanks, > > Zameer Manji > >
