-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41804/#review115175
-----------------------------------------------------------

Ship it!



src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
(line 178)
<https://reviews.apache.org/r/41804/#comment176074>

    This will need some adjustment to keep the improved failure mode introduced 
in https://reviews.apache.org/r/42375/ alive.



src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java (line 47)
<https://reviews.apache.org/r/41804/#comment176070>

    Odd blank line whitespace in this interface.



src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java (line 
67)
<https://reviews.apache.org/r/41804/#comment176071>

    The defaults aren't applied consistently here, not sometimes at all in the 
Params interfaces above.  Its not important to get this right until the RB that 
takes away the Arg fields though, so I'm fine with reading this change as 
providing some examples of how this will work.  My takeaway , based on optional 
options being - hopefully - the norm, is that The Params methods should either 
return Optional and have no default implementation or else have a default 
implementation.  Non-Optional pure abstract Params should be viewed with mild 
suspicion.


- John Sirois


On Jan. 18, 2016, 5:26 p.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41804/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 5:26 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This begins to define a proposed replacement args API, from the perspective 
> of the code consuming args.  Args will be defined in interfaces, which the 
> eventual arg system will be responsible for implementing on the fly 
> (mechanism TBD).  So while what is seen here is a large net increase in code, 
> the eventual conclusion will be roughly equivalent in terms of lines of code 
> in `Module`s.
> 
> This begins to enact work described here: 
> http://mail-archives.apache.org/mod_mbox/aurora-dev/201601.mbox/%3CCAFWq12VJPOxDViDP5OsmXU3skHR6rrp5Zp%2BXgi8HgeHic6pTJw%40mail.gmail.com%3E
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 6b71fd233af0d137332bc69249d16e433aa198c7 
>   src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java 
> 45ab76b9331a79699979c6386c93bbc763f64e2e 
>   src/main/java/org/apache/aurora/scheduler/SchedulerModule.java 
> ddc0d0500b8788bc2c9dd67abb62a412465488b4 
>   src/main/java/org/apache/aurora/scheduler/app/AppModule.java 
> a25fa41f2cc0b1dd8e7915f576cd52bab77a2b21 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 0659c358479283756179c2cabebc8416730cc3e3 
>   src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java 
> da07df66b06cef6223119854032b4ca1c57a0859 
>   
> src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java
>  949c299bdbc54f976db994266fb97f3099256f13 
>   src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java 
> 155d702d68367b247dd066f773c662407f0e3b5b 
>   src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java 
> 01d6b5de0079d6f5709c29fe9a72829fbc8501de 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> df649ff4ffdc741afdbc4850c2dbf98bd3e218f1 
>   src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 
> cd5adf9655dc3368dbe06bfee15c65182176be2e 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java
>  e32862034a1ad47dae8fff89cb04deb34ccd90e2 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java
>  43c38dcffd8e68c018217681cc5a3073d9fb1437 
>   
> src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java
>  0f8bdbbf77dd23c6c370e26a7e1dbc3f1a4ebfe0 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> 906b3494ab35e70397927ec13f3d9a814059575c 
>   
> src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
>  7de8f4cebcda51953e00322caec6ad278951f6b1 
>   src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java 
> 90f8abf830478ad48f9a8a62c1c42423ab0f8d57 
>   src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java 
> 23d1c120657d5cb9d294a80c63e8a04512d361ca 
>   src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java 
> 735199ac1ccccab343c24471890aa330d6635c26 
>   
> src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java
>  cccee083fc2e5f204c91a9d397beb451d4d9df40 
>   src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java 
> 577edcbf362493d577e2f12c876f1dbb9387ad79 
>   src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java 
> d569241a59f169eaa9982c3bba7003aa4942f50f 
>   src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
> 08eb6d6c722950f6bc75c97ce12380eca16e704d 
>   src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java 
> 4767ef12e6a3c9d7b2d4a2b5be27786518b5b612 
>   src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java 
> cded40ba4981e0ae287b6a24e49523f40674bef9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 2b3ee7bf6f7801c140f921b25f78daf6d320098a 
>   src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java 
> ed63a7471d654dcefd2ff24e2e462974883541f2 
>   
> src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java 
> 1b491f977cf3a81e61f1333082be0547420306d4 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
>  5b59d55b8e58d0231a18da9813045a9d1dd70be3 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 9fb8aad5d1c0412efc6d1176e543321ebe503e03 
>   src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 
> 4716b66307bad16ecf29ec977e033e31f090fc9d 
>   src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java 
> 19c8a1fe06a333324022da11f74d7c96b2942587 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
>  3e811a4f4d2c82892217ca1f950ac792303fbcf3 
>   
> src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java 
> 2c3e5f32c774be07a5fa28c8bcf3b9a5d88059a1 
>   src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java 
> 341e346e794c9cf9a2789b8799f38fff900ec9b3 
> 
> Diff: https://reviews.apache.org/r/41804/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to