----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42532/#review115313 -----------------------------------------------------------
Master (fe13e4e) is green with this patch. ./build-support/jenkins/build.sh However, it appears that it might lack test coverage. I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On Jan. 20, 2016, 1:28 a.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42532/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2016, 1:28 a.m.) > > > Review request for Aurora and John Sirois. > > > Repository: aurora > > > Description > ------- > > This reverts commit fe13e4ed52d4dc0a35f9e50b5e49c6e705f64579. > > I'd like to back out this change until i overcome some hurdles with the > follow-up args replacement patch. I don't want the code to sit i this > intermediate phase, so i'd rather revert. > > > Diffs > ----- > > config/legacy_untested_classes.txt 30d4b13223edf2ce9f23bda5bebacc686cbb0261 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 3ce266a7025b1851c092c3f699eba861547e5315 > src/main/java/org/apache/aurora/scheduler/SchedulerModule.java > 83e90603488a0be02b8178b31a9bd2a64e47c010 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > 58026e1a442c9371c7dab7194a24998e138b3009 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 0861c4e9adc6dfb991aa3debc0e32b617cc7544d > src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java > d30786169c31598f81b959011d440e3cd1d21fce > > src/main/java/org/apache/aurora/scheduler/configuration/executor/ExecutorModule.java > 8c58c5ba9454c9b75746beb6fa1ba4f1816decac > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronModule.java > c16531753ed9280046e918f2228c8837b0f24bca > src/main/java/org/apache/aurora/scheduler/http/H2ConsoleModule.java > f96516198f5547e75b9e1b6539689ec3f677664b > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java > 33e3cd8b20cb75ce2ee03b917e0b101fce4c3046 > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > b37278bdae003719166968152eba3ff4399ea397 > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java > d305112f7e85fe9be82aa73bb72aad9db0e970b0 > > src/main/java/org/apache/aurora/scheduler/http/api/security/IniShiroRealmModule.java > 209a7140f2cfc6cc0eaf7a5e3233f24659d889e4 > > src/main/java/org/apache/aurora/scheduler/http/api/security/Kerberos5ShiroRealmModule.java > 0090567a1c465e18548def578d738cf8ebc48d6b > > src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java > 9482d7487fa42082d2f48ffad579d5efe0dc1c39 > > src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java > 4c41576fa625811e431078ce8dbfc06f95b05246 > src/main/java/org/apache/aurora/scheduler/offers/OffersModule.java > 39b4ab189b2a7757292843b6f59ac1783e7a2873 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorModule.java > e58688ac7b6c4addf64545bfc943e00551deab52 > src/main/java/org/apache/aurora/scheduler/pruning/PruningModule.java > be10bff5a2080ebcc93fdcc7cf55319523a409ab > > src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java > b8e2c0a8f136c3ff2ab34cf8e1e6392df4ff4e60 > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java > 150c654841b4f66dbbcff9c541f4ee733d47bc15 > src/main/java/org/apache/aurora/scheduler/sla/SlaModule.java > 159a88456297f43a38480d4b1738ac2f6d48cd0e > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java > e8d1e14bf3f79d298892be70e2e2a11d566c2af4 > src/main/java/org/apache/aurora/scheduler/stats/StatsModule.java > c56ff3c9264d731994212c4e32b4f44da5fe61aa > src/main/java/org/apache/aurora/scheduler/storage/backup/BackupModule.java > 38bf1aa0183df25e07492563f39a8423dde75a10 > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > b4deef0a397690e2ce4b36fb03d794781f82e7f6 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorageModule.java > 07ec54cd6ec542075ff78ffe3a80d792cae12314 > > src/main/java/org/apache/aurora/scheduler/storage/mem/InMemStoresModule.java > 8909833cadc0baffe11d4b50842eacadd537f34e > > src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java > 483829365ba63a21e490f415bacb7211b45d2729 > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 35292a2bca9eb26455d48b8605ad2a86354d3e80 > src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java > 650cde6bcded5178f1e427b034f819393e1b0f59 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 9c40aaf0e69d4b9239e81d965516f77c81e3eb1b > > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java > 0c9d4f6af9ac64e3ad4b57f46e6f38217d95df53 > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java > 0bbb687e7b6e63e8a6333cabc752686a51f0e81e > src/test/java/org/apache/aurora/scheduler/sla/SlaModuleTest.java > fe8c28260c801142319834cd25a8e813dd14ab95 > > Diff: https://reviews.apache.org/r/42532/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >