----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42613/#review115688 -----------------------------------------------------------
Ship it! Ship It! - Maxim Khutornenko On Jan. 21, 2016, 8:25 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42613/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 8:25 p.m.) > > > Review request for Aurora, John Sirois and Zameer Manji. > > > Bugs: AURORA-1580 > https://issues.apache.org/jira/browse/AURORA-1580 > > > Repository: aurora > > > Description > ------- > > Proposing this as the minimal fix for AURORA-1580. I think it's wise, > however, to look towards the alternative approach i described in that ticket > for simplicity and performance gains. > > I'd like to note that after this change, it will be important to treat > long-running transactions carefully. It will be important to avoid > transactions block others by writing (locking a table) and subsequently doing > other lengthy work. > > > Diffs > ----- > > src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java > 2b3ee7bf6f7801c140f921b25f78daf6d320098a > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml > e689cfeda39e1f065ed29c61a23376512df8f3aa > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > 3dba286556ab6ea34b7fdd38508a164c902d9d17 > > Diff: https://reviews.apache.org/r/42613/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
