-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42628/#review115754
-----------------------------------------------------------
Related discussion, i would like to evaluate removing this function:
```
ImmutableSet<IScheduledTask> mutateTasks(
Query.Builder query,
Function<IScheduledTask, IScheduledTask> mutator);
```
The function itself is only called in `StorageBackfill`, and could be replaced
by a query + selective mutations.
- Bill Farner
On Jan. 21, 2016, 5:25 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42628/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 5:25 p.m.)
>
>
> Review request for Aurora, John Sirois and Maxim Khutornenko.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> This is partially in response to some discussion on other reviews.
> `fetchTask` makes several call sites much more natural (not having to
> possibly deal with multiple results), and `mutateTask` actually represents
> all but 2 call sites that modifies tasks.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/StructDump.java
> 4fa5254457b40feb4bb8b6512c09dd4946935b64
>
> src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java
> c136d1abc82b0f91f2b148e998e30b6b50856d51
> src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java
> 720b5e5d14a66412dceaf9d9954c7f5aa01d495c
> src/main/java/org/apache/aurora/scheduler/storage/Storage.java
> 610915820b50a73f6757ad60a0e35e3f641f7fdf
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java
> 62639c4879ecd652f4d51a94159f128997c03df5
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java
> d4061340dc4d9975b6783b6cb38b457632bd4bb0
>
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java
> c44ff47d7dffc0880bcdb84ed26f53bcb7d45e0e
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java
> c55dcc94a4ec080fedf85ee792c968e8f119f53a
>
> src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java
> b380f21ac169b4991158f39dc70526e11fca54f0
> src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java
> 6d4268956acdf85465a3d05191456c74bc426998
>
> src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java
> a6bfc7ac91891330600bd260cc8efff1240007e1
>
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java
> 5a9b6c1030a6db2190d34bf531deb99dfd8df672
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java
> 430527051df7cd7026ae2754f5a9616e39857468
>
> src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
> bf344a4ddbc7f294f938df67f27bfdb32cf37457
>
> Diff: https://reviews.apache.org/r/42628/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
