----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42639/#review115911 -----------------------------------------------------------
Ship it! Ship It! - Bill Farner On Jan. 21, 2016, 6:47 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42639/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2016, 6:47 p.m.) > > > Review request for Aurora, Maxim Khutornenko, Bill Farner, and Zameer Manji. > > > Bugs: AURORA-1582 > https://issues.apache.org/jira/browse/AURORA-1582 > > > Repository: aurora > > > Description > ------- > > This eliminates processing all futures to find the 1st failed one in > favor of directly signalling a Service failure when a unit of async work > fails. > > src/main/java/org/apache/aurora/GuavaUtils.java | > 18 ++++++++++++++++ > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java | > 56 ++++++++++++++++++-------------------------------- > src/test/java/org/apache/aurora/LifecycleShutdownListenerTest.java | > 17 ++------------- > 3 files changed, 40 insertions(+), 51 deletions(-) > > > Diffs > ----- > > src/main/java/org/apache/aurora/GuavaUtils.java > 8c2ab5720b808e5eae4c6b93fea8b787839b8dbe > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > 2d4c58eaa930c561446320a77a559cd926318e8a > src/test/java/org/apache/aurora/LifecycleShutdownListenerTest.java > 8d19c04a96fccdd9594ecf783fc797c2b76140c7 > > Diff: https://reviews.apache.org/r/42639/diff/ > > > Testing > ------- > > Locally green: `./gradlew -P build`. > > > Thanks, > > John Sirois > >
