> On Jan. 22, 2016, 7:44 p.m., Bill Farner wrote:
> > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java,
> >  line 444
> > <https://reviews.apache.org/r/42666/diff/1/?file=1212356#file1212356line444>
> >
> >     Nearly forgot - in this branch, you should log and return a deprecation 
> > warning.  Cmd-f for 'deprecated' in this file and you will spot an example.

Done.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42666/#review115910
-----------------------------------------------------------


On Jan. 22, 2016, 6:47 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42666/
> -----------------------------------------------------------
> 
> (Updated Jan. 22, 2016, 6:47 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1583
>     https://issues.apache.org/jira/browse/AURORA-1583
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Following the path consistent with restartShards using JobKey + instanceIds.
> 
> 
> Diffs
> -----
> 
>   NEWS 37a7a7933b20e112416b01260d97fc2f47c24027 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> f099620967a7836538f19545fe373faa335529a4 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  69eab90fa053c917a6a2c60b548802ba450fa80c 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java
>  f6669efe9d00ead3f123dda6f6152ae273e1a6c4 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ac4e6f209e4bd8a9923c6cff17b1ef1486bf3ab6 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java
>  3e811a4f4d2c82892217ca1f950ac792303fbcf3 
>   
> src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java
>  79e70fde1633e6dfbed2171cceee0197acae2550 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
>  d12b56eb675e5187fb375a27ace3849fdab1dd8d 
>   src/test/python/apache/aurora/api_util.py 
> 5b2a5383ffa490dcf651c027074ed42bba0ab644 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> 2daa96c4725ca24b8bd17f9dbdbbdc463b0facf8 
> 
> Diff: https://reviews.apache.org/r/42666/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to