> On Jan. 25, 2016, 3:55 p.m., John Sirois wrote: > > NB: Please hold off on review pending an email to dev@ explaining this 3 RB > > proposal.
Review away, accompanying proposal is now out for review: http://markmail.org/message/a6sdqcelgokw6mwz - John ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42756/#review116204 ----------------------------------------------------------- On Jan. 26, 2016, 11:37 a.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42756/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2016, 11:37 a.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1185 > https://issues.apache.org/jira/browse/AURORA-1185 > > > Repository: aurora > > > Description > ------- > > This eliminates the `I*` entity wrappers in favor of 1st class immutable > thrift entities as well as eliminating both `AnnotatedAuroraAdmin` and > most hand-coded db view classes in favor of the new thrift codegen > support for passing through thrift annotations as java annotations. > > Most changes are mechanical conversion to the new immutable thrift > objects and generated `Mutable*` peers, although some new code is added > to handle both the swift codec stack and the thrift client and server > plumbing. > > 291 files changed, 7008 insertions(+), 6911 deletions(-) > > > Diffs > ----- > > > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > PRE-CREATION > api/src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > PRE-CREATION > api/src/main/thrift/org/apache/aurora/gen/api.thrift > a93df2165c208c4963975aeb4f174df602baa476 > api/src/main/thrift/org/apache/aurora/gen/storage.thrift > 6dc46147bb0703e83a210a81ee24081183389a89 > > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftEntitiesPlugin.groovy > 3acd7e938d4d1e657cf59abeddac80076705ba57 > buildSrc/src/main/groovy/org/apache/aurora/build/ThriftPlugin.groovy > fc2bc9082dae2c63aa578c05dc89feb346260a67 > > buildSrc/src/main/java/org/apache/aurora/thrift/build/gradle/ThriftGenTask.java > PRE-CREATION > commons/src/main/java/org/apache/aurora/common/thrift/Util.java > 4ef7f49b7953b56b592b2f8ac3e04df738615211 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSetImpl.java > eca13511dc93f5ce5879976f2c7b0cc40be7d342 > commons/src/main/java/org/apache/aurora/common/zookeeper/ServerSets.java > 01a54a5718388df7f02992388653d7b049422787 > > commons/src/test/java/org/apache/aurora/common/zookeeper/ServerSetImplTest.java > 56cc32d95041b8c27932c0ee17bd36c83756cb3a > src/jmh/java/org/apache/aurora/benchmark/BenchmarkSettings.java > 94f8b799c15601758aed1c5458ad7af79bda6bbb > src/jmh/java/org/apache/aurora/benchmark/Hosts.java > d95e2dd3f736eefd586f707ba2559f8db7650857 > src/jmh/java/org/apache/aurora/benchmark/JobUpdates.java > 493f75dbf6b44449403e5fb5bb48306336880d54 > src/jmh/java/org/apache/aurora/benchmark/Offers.java > 055a2ffcb13c643a3086343e3fbf71545c5fb0a6 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 45ab76b9331a79699979c6386c93bbc763f64e2e > src/jmh/java/org/apache/aurora/benchmark/SnapshotBenchmarks.java > ca484fab2a9b136c6d5b9be31e1ad1a5360f1b7a > src/jmh/java/org/apache/aurora/benchmark/StatusUpdateBenchmark.java > dc1ef82bce9e8e243974f8b97165f4417d870a7e > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 > src/jmh/java/org/apache/aurora/benchmark/ThriftApiBenchmarks.java > 293b88f462183cc85b02aaf875e887d21f4552c5 > src/jmh/java/org/apache/aurora/benchmark/UpdateStoreBenchmarks.java > 1d8986ba117f32288510c299ea5634f90a9311e7 > > src/jmh/java/org/apache/aurora/benchmark/fakes/FakeRescheduleCalculator.java > 4af2339a4ba6bcb5bf30e4739ebce7e20b387b16 > src/main/java/org/apache/aurora/codec/ThriftBinaryCodec.java > 6b65c0f6cb60b98ff352c4c5d5fed38d52b4b062 > src/main/java/org/apache/aurora/codec/ThriftServiceProcessor.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/HostOffer.java > 53fd68c6622d5cb06c0fc3efe002c11fbb9d08c5 > src/main/java/org/apache/aurora/scheduler/ResourceAggregates.java > a6335c53697a8bd51ba15d60216446c466b5d6a6 > src/main/java/org/apache/aurora/scheduler/ResourceSlot.java > 86f2667a323ca32756fd2dbc0e918bdf0362239d > src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java > 35675acfad8f98e833e0dba277ff65943a21db91 > src/main/java/org/apache/aurora/scheduler/TaskVars.java > 6351cc74c152d1f902078154ad14376c19c6ef1a > src/main/java/org/apache/aurora/scheduler/TierManager.java > 7367df4a030a3698518c9059aebcafc63c88e920 > src/main/java/org/apache/aurora/scheduler/app/AppModule.java > a0d2a717534bbb2e85a556721cc53c1e4b743461 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > cd9cb09a889984d9cb9d63b890093a075647dcbf > src/main/java/org/apache/aurora/scheduler/app/VolumeParser.java > c1e99cee7a824b1440c9ef8c23c0d6834b6a1394 > src/main/java/org/apache/aurora/scheduler/base/Conversions.java > f2ff7abb51101c603df1bd1b21c4920a348743e1 > src/main/java/org/apache/aurora/scheduler/base/InstanceKeys.java > b12ac83168401c15fb1d30179ea8e4816f09cd3d > src/main/java/org/apache/aurora/scheduler/base/JobKeys.java > 8f5bf58b963ae5f76aad7dfa34bae5b9e67d6242 > src/main/java/org/apache/aurora/scheduler/base/Jobs.java > 49e5b2cfc0b84bb0e0c95cca375cd0503f9dcdb5 > src/main/java/org/apache/aurora/scheduler/base/Numbers.java > 703ca3b707320bbda48fa89c45404093b241e785 > src/main/java/org/apache/aurora/scheduler/base/Query.java > 7bf0afb5c4d53942cb11b7e405196c94590bd75c > src/main/java/org/apache/aurora/scheduler/base/TaskGroupKey.java > 06fc58439c49acedbcfe09a27ef6d483d290af30 > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > 02ba1e3099ea5e1c4422e5b663b937365e1deb22 > src/main/java/org/apache/aurora/scheduler/base/Tasks.java > 9f625c775544d9ae4d8e5b15e1fc824ed4a876c8 > src/main/java/org/apache/aurora/scheduler/base/UserProvidedStrings.java > 80fc79003789304a7c653807068297f4d446809d > > src/main/java/org/apache/aurora/scheduler/configuration/ConfigurationManager.java > e4dbf06f41dddcbfb14521f8ceb9406b967713ee > > src/main/java/org/apache/aurora/scheduler/configuration/SanitizedConfiguration.java > 264cb7cb38809a3a37b13b76e93f423ec03fbacc > src/main/java/org/apache/aurora/scheduler/cron/CronJobManager.java > dcd45646ee83b63e1e3c88fedc3ae61ee76b9c5b > src/main/java/org/apache/aurora/scheduler/cron/CronScheduler.java > ac45f1544f0713d10b7bb6a8d44a1f3f3bd980c6 > src/main/java/org/apache/aurora/scheduler/cron/SanitizedCronJob.java > 87970f6c4139a6391be88a91661500e6cc7bf101 > src/main/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJob.java > 7d41a53d01206f06badda16e0149e8ad37dc5a69 > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImpl.java > 850effce75bc031eadaf5cc617e6d32e242c3403 > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronLifecycle.java > 650facecc2e02be7bb3cd5ea9ff0f094e006bcb3 > > src/main/java/org/apache/aurora/scheduler/cron/quartz/CronSchedulerImpl.java > ead85c34fe6c8cc9d93329bf5d6e4595a044f201 > src/main/java/org/apache/aurora/scheduler/cron/quartz/Quartz.java > c379a32c6d38081c6f5f340c7551aa2a24e315a0 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java > 87b9e1928ab2d44668df1123f32ffdc4197c0c70 > src/main/java/org/apache/aurora/scheduler/filter/AttributeFilter.java > 88efda041da9332b68d71801474935153d103b9b > src/main/java/org/apache/aurora/scheduler/filter/ConstraintMatcher.java > d4099c28e411a0fd81c11b5d32585a6473240fba > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java > 1e8eb0cabb47cdfab30d63d643be0b929b93a8c0 > src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java > e9ee049e51e72fcf670ff74db6c3a9f83ab5622d > src/main/java/org/apache/aurora/scheduler/http/Cron.java > e81ab25a59e8eaee961fcdce96a358e39b33fd91 > src/main/java/org/apache/aurora/scheduler/http/LeaderRedirect.java > ef712909f6a32882a1ca9d4863a44754b3e94e15 > src/main/java/org/apache/aurora/scheduler/http/Locks.java > 0931289c0753b2dcad473baaf85e47cbf46506cd > src/main/java/org/apache/aurora/scheduler/http/Maintenance.java > 72c8c3e52599ac98bd730e6be6b7b15dffe57cdd > src/main/java/org/apache/aurora/scheduler/http/Mname.java > d6e5fc4e886660311228d411cae1bbb42aaffb19 > src/main/java/org/apache/aurora/scheduler/http/Quotas.java > 399203bba5088adfa3d418ff8ac5339b2d0aa94e > src/main/java/org/apache/aurora/scheduler/http/Slaves.java > f63fb7be35e2d538d34f6c4a88fb191916d7ab6e > src/main/java/org/apache/aurora/scheduler/http/StructDump.java > f84767a2c01bccc23182672123f9ca6701fcd696 > src/main/java/org/apache/aurora/scheduler/http/Utilization.java > 4a609e368a451f3f3b0b0fde9770aed213325f0d > src/main/java/org/apache/aurora/scheduler/http/api/ApiBeta.java > 053b87b3e4b7d9995395e372fc11cfd5dc7034c4 > src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java > cd5adf9655dc3368dbe06bfee15c65182176be2e > > src/main/java/org/apache/aurora/scheduler/http/api/GsonMessageBodyHandler.java > 44295f80ba8b464d502e72c11c517fac28716c59 > > src/main/java/org/apache/aurora/scheduler/http/api/security/AuthorizingParam.java > 73c539bba6b2bd864afa2eabe98efde4aca2813d > > src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetter.java > b2ca0122d72303fc6f052b59a0ae21ea75810040 > > src/main/java/org/apache/aurora/scheduler/http/api/security/FieldGetters.java > a833672cd13db7ab6d35a5bb621e6d591b9dea12 > > src/main/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityModule.java > e32862034a1ad47dae8fff89cb04deb34ccd90e2 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthenticatingThriftInterceptor.java > bf7828b37171c162101a6def80e27c470c806a56 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingInterceptor.java > 8fa8e121f5c7becf8f7ab7a8e5d95e1612d69ab8 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptor.java > 21e565ebe64971359c81426709b47c7c9cf3900c > > src/main/java/org/apache/aurora/scheduler/http/api/security/ShiroIniParser.java > 3ee41b81b7e30375e63f310ed44ce8a1381a6722 > > src/main/java/org/apache/aurora/scheduler/http/api/security/ThriftFieldGetter.java > 2044b7985bd5f56c90c6e3140c2a505fea0cec19 > > src/main/java/org/apache/aurora/scheduler/http/api/security/UnauthenticatedError.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java > cc06b85f30f6e0865a4e45606103cceedb41eaf7 > src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java > fcad0e735b676e8da9b2b1d4d0d5e734a717b2d8 > src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java > 394d25f8a496ee24505387e5767acf458cb3f5f4 > src/main/java/org/apache/aurora/scheduler/preemptor/ClusterState.java > ce3bc7e6da3f86625c690e26c28ccef67ed9021a > > src/main/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessor.java > 5687bc511c92682594f2cb89a00cd16ca8a894b3 > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictim.java > 7d92843504ef3cf17db7c780fc488451600cd6ba > > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java > 7f84e90774193b0d31adb7dafcab0a249167cdba > src/main/java/org/apache/aurora/scheduler/preemptor/Preemptor.java > 7d2903a47dacfc35f9e547ccb6c5896efe3e013f > src/main/java/org/apache/aurora/scheduler/preemptor/PreemptorMetrics.java > 30bb814148b271cc9dfeebe016e8f8f92c2e3e41 > > src/main/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPruner.java > 6ab39ca0a64dfab9fe2fdec79fef1b4d320b6dc6 > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java > 5441630522b3855a3b2036b5ff66fe980728ec68 > src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java > 3437c65af27993ea50bf39d322558fb64a645da1 > src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java > 1df21b8d82ee48fd4d2f11d77aa419dd91c2a33c > src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java > c18836a33341d56569763d6bfe3213e49110a26d > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > 57d20618fe9eda076936d159172d5e133ec6597b > > src/main/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculator.java > 4b0ef81e5dd2723291a9810980246c6c3e7924f5 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java > c044ebe6f72183a67462bbd8e5be983eb592c3e9 > src/main/java/org/apache/aurora/scheduler/scheduling/TaskScheduler.java > b0c6070ec0562c951ca7046cb41f93679a5beeb2 > src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java > 3ddac8b9c0adb0e2e7d02b1a741e9ff6976b3c9e > src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java > 4f243aab5a2c2f86ec795025e86302a09f864e2d > src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java > bf7c0840dceb2fe586692158dee4114d4def9c83 > src/main/java/org/apache/aurora/scheduler/spi/Permissions.java > 843621c455a0eed11e0784216a3756e9252271d9 > src/main/java/org/apache/aurora/scheduler/state/LockManager.java > 07de8fc0458cc3a2b2c49bc6962056ae5d5bbe9c > src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java > 59c9786e07fbaf167aefa4e5004d7b2abe6bda57 > src/main/java/org/apache/aurora/scheduler/state/MaintenanceController.java > 3c7cda09ab292d696070ca4d9dfedb1f6f71b0fe > src/main/java/org/apache/aurora/scheduler/state/StateManager.java > 5d34fe38492cae3f50ea9ed0baca11472295af60 > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java > e5b2f41f55aec161840c3fb17f2ff73161b77482 > src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java > 0c467a65798c86efd9d0b60e5a53c5d5289fb54d > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java > 6fd29512ace01f98024fd3b6db00e6c903ea8b89 > src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java > 08eb6d6c722950f6bc75c97ce12380eca16e704d > src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java > 5231e9f547004534c027289111544e707a64e6ec > src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java > c9e57ececc5981c92248fd9974cf31dd71dd33e1 > src/main/java/org/apache/aurora/scheduler/storage/AttributeStore.java > 981bdcf665fdfa710608c57e7b7817d286dab373 > > src/main/java/org/apache/aurora/scheduler/storage/CallOrderEnforcingStorage.java > de4ada431634fb171fab109f1923da810b361205 > src/main/java/org/apache/aurora/scheduler/storage/CronJobStore.java > d78474af5eff26fa9574347a4c4c7c2cbe50c0a7 > src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java > 52c3c6618a3cf1009435ca8a9cece36365913e55 > src/main/java/org/apache/aurora/scheduler/storage/LockStore.java > 9764a0102dd74b020abcbed7b96394d5e1b98591 > src/main/java/org/apache/aurora/scheduler/storage/QuotaStore.java > 688eb56c3073c73c271f3d2c80f356dae3f9c02b > src/main/java/org/apache/aurora/scheduler/storage/Storage.java > 578bb37de8853c4228e76b31f601430b7170946a > src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java > ac0bb374842741d7ccb7a83c574a90ac156af0f9 > src/main/java/org/apache/aurora/scheduler/storage/backup/Recovery.java > b74de9b51fd01788a3970e56a534a3b9adcd8863 > src/main/java/org/apache/aurora/scheduler/storage/backup/StorageBackup.java > 92b7b82a2eeaf7688606645cedc837d4467ee1bc > > src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java > 46b3d104931f175314902ccd39b81c4b6d67d4f3 > src/main/java/org/apache/aurora/scheduler/storage/db/AttributeMapper.java > a454887c27dfc80d753afb2b2c4b20fd330aea59 > src/main/java/org/apache/aurora/scheduler/storage/db/CronJobMapper.java > b07928d667f4b77330524f97178dec775ddb9a42 > src/main/java/org/apache/aurora/scheduler/storage/db/DbAttributeStore.java > 69010985aa066ebb6686f256a734d77e008ccd1a > src/main/java/org/apache/aurora/scheduler/storage/db/DbCronJobStore.java > 6a9c73e8e6dd92e9e6361baa0e02ccaf89fce5d7 > src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java > d2673e6b328cb1e249fbe91d18e0d9e935636eaa > src/main/java/org/apache/aurora/scheduler/storage/db/DbLockStore.java > 9e28550c6e9e7e9cfdeb0bbfe3e4ba39f0148336 > src/main/java/org/apache/aurora/scheduler/storage/db/DbQuotaStore.java > ac63e67fa9770cc0de6f075e513f089a291f32f0 > src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java > b899d0f11ea499e40298ea9020414997c4527821 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobInstanceUpdateEventMapper.java > 591b781239b0132c436fbc7eeb5e36b98e7640e9 > src/main/java/org/apache/aurora/scheduler/storage/db/JobKeyMapper.java > ac0a998de560c0198b3206024285a2a6306b60bc > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.java > a3b04949f1726f110638e4f93ef45947cdb9e7f8 > > src/main/java/org/apache/aurora/scheduler/storage/db/JobUpdateEventMapper.java > d1a3c3f115e8dcb83e400a9a55c126c06a3cfaf7 > src/main/java/org/apache/aurora/scheduler/storage/db/LockKeyMapper.java > 9760674adab98d612a17420f91d5a644465f61f1 > src/main/java/org/apache/aurora/scheduler/storage/db/PruneVictim.java > 144f5a3cc6f1323d351f7c37685230bc824cbe39 > src/main/java/org/apache/aurora/scheduler/storage/db/QuotaMapper.java > 3e5c4342a3a56f4a19d824d9219ec9f2a8142f75 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigManager.java > 27f1f33ffc782b3d2a2a9add494c04911659e217 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.java > 12ca16b79a062d9ea15c206ef963fb077ad7ad98 > src/main/java/org/apache/aurora/scheduler/storage/db/TaskMapper.java > 4bf40047e105389ac7139edc449857889d390106 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbAssignedTask.java > 93722395ed9fcd22dcb12e34e648e6e410952d43 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbConstraint.java > 93667574ce97bd224b8de58d424efdbfb0114217 > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbContainer.java > ae97638fa544dd8f8afbaa19b1dd31f5a1dc43d8 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbInstanceTaskConfig.java > f3fd7a96326408a990ab5014b86336759902f462 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobConfiguration.java > 40a5013b62d459d9c766c765f9e536f7042757e1 > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdate.java > 78703e92c932cd5e93ff0b70f2a0b6928f6b4003 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateDetails.java > 3a5272471e15177a35397acea920198499d16f0b > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbJobUpdateInstructions.java > d19aa859bcc5da2c9c7d4ebbb8db307a1ea2883e > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbScheduledTask.java > 502a1fa6fc141df498f0f09af292ce24e269731d > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbStoredJobUpdateDetails.java > 8ec6d4710964fd64d24774a719baffa27502c607 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConfig.java > 16f2cb143469974efe4dc191c13788d8b8e21c57 > > src/main/java/org/apache/aurora/scheduler/storage/db/views/DbTaskConstraint.java > e3e1b7ae25a63e13e2dc288d29c4cd3ea416915f > src/main/java/org/apache/aurora/scheduler/storage/db/views/LockRow.java > aaa0a68ae936e3ba095de940aad7184a1de50a31 > src/main/java/org/apache/aurora/scheduler/storage/db/views/Pairs.java > 922578f0e545de67cfd26a601af29f00882a2a09 > src/main/java/org/apache/aurora/scheduler/storage/log/Entries.java > ab7cd2d40013827122e27275f557e9c8fff9dbb7 > src/main/java/org/apache/aurora/scheduler/storage/log/EntrySerializer.java > dea2bdab1e8dfc5de950a53f5bd3fb98b1b0aa9a > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 042f71dd8bc81d03f2759ee7f7f4b65a098d11e2 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java > 9733ffe74b107f336858657550156ddb1f1dd215 > > src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java > db90150b48c5b134dde6c69f70ebca82bfdd0c12 > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java > 76a574fd4fb18e0afd8da6387286b72cc583b7fd > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java > 766ec2d51ac875ce263d7e4ad8827424555b5b5e > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamTransaction.java > a51fd18ad00537bf244419442078548d8545a841 > > src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java > 2f07afb73f6e585a6b43be68134e2beecac83d31 > src/main/java/org/apache/aurora/scheduler/storage/mem/MemCronJobStore.java > 365494c0bfca7b633c57bf97762473df458ef1aa > src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java > 231a55615abfbb483667f5f8ef71d2709fc16a88 > src/main/java/org/apache/aurora/scheduler/storage/mem/Util.java > c28fb65010af5e3db925487929d4e0e12b4101a4 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > d326d24dd527d084bce1b300f1818d3b1d94c036 > src/main/java/org/apache/aurora/scheduler/thrift/Responses.java > 01afe006fd42d17c0d9a114dc0d378cf2016c6ec > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 662cae179142b34896b11275bd3b425903f22e3e > src/main/java/org/apache/aurora/scheduler/thrift/ThriftModule.java > bd92ff79c86c8b018583f4bc860c64e63a0d36e1 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java > c374343a44bd5cc2e74c96b5cdf3760d0ff3278a > src/main/java/org/apache/aurora/scheduler/thrift/aop/AopModule.java > f59ee1a0514a6dc52573c0b932cba755e0a10e18 > > src/main/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptor.java > e0d6c564aa9705228ec4423ffee7cdd435b86d0d > > src/main/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptor.java > e3ab28391c297489b1a52797fe4185810d0a2138 > > src/main/java/org/apache/aurora/scheduler/updater/InstanceActionHandler.java > 11ffa663e4e0fa5fda0ebb343d11d2485a83c7c6 > src/main/java/org/apache/aurora/scheduler/updater/InstanceUpdater.java > c129896d8cd54abd2634e2a339c27921042b0162 > src/main/java/org/apache/aurora/scheduler/updater/JobDiff.java > 7257ee8017c4a9131f60234fc21fe5a15fe0d023 > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java > f8357c46df1b025bf4e38a7ce1cb1c13a50c39f9 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > 48d7e2afb795a743ca9ca3e125a02195e45f1f67 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriber.java > c01cf9222f03db44f69c414f7e68524e5eea7e31 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java > 7ab739a4dfa292895ad6ba8849e65f5c45ce9770 > src/main/java/org/apache/aurora/scheduler/updater/UpdateFactory.java > ac8df3e5a2da8cf22e1ba8a90944546e19ccdcaa > src/main/java/org/apache/aurora/scheduler/updater/Updates.java > f949fd54f524780672167e12fcadf268da08e679 > src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py > e9e9368328992cb8cc26eb22d86aa244d5fa9250 > > src/main/resources/org/apache/aurora/scheduler/storage/db/AttributeMapper.xml > 41519dee391a37ff4904b6c52dc276d278b85f1f > src/main/resources/org/apache/aurora/scheduler/storage/db/CronJobMapper.xml > ee603f42ce58e2cc73e4648f0c2f084d338c235b > src/main/resources/org/apache/aurora/scheduler/storage/db/JobKeyMapper.xml > 3b5a7c9f37e4e947c11735972024920b94f61a99 > > src/main/resources/org/apache/aurora/scheduler/storage/db/JobUpdateDetailsMapper.xml > 69e11b69c4d8e0e2cba4c30ecc56077b2a3245ad > src/main/resources/org/apache/aurora/scheduler/storage/db/QuotaMapper.xml > 0283ec1d8fbb81f25439852a6a417f7d8ae01809 > > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskConfigMapper.xml > 4e8966dc29689573a5ee3ba4c29392c3a7d14208 > src/main/resources/org/apache/aurora/scheduler/storage/db/TaskMapper.xml > db6c642522c422946eb3933859a2c3415e684cfe > src/test/java/org/apache/aurora/codec/ThriftBinaryCodecTest.java > 999ef064737c3d8a3d7610b40c13736f51742edd > src/test/java/org/apache/aurora/scheduler/ResourceSlotTest.java > 52113b80d91ecaf0cc2aeaad77e5fbc0ea4d1216 > src/test/java/org/apache/aurora/scheduler/TaskVarsTest.java > 05cd78f4c7c7d8dd6eeb6f2f9a3e8f7a167f274d > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java > 350b90b7333b5e8f195909eeca915ad91d7307fe > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 39916f5ceffec788046a4cc4c4e33aed4d57513b > src/test/java/org/apache/aurora/scheduler/app/VolumeParserTest.java > e8f8449b967f15a85219c2be57556db78f42f57f > src/test/java/org/apache/aurora/scheduler/base/JobsTest.java > 13f656f241a8a9a3d339f4053f165070c2669ef3 > src/test/java/org/apache/aurora/scheduler/base/TasksTest.java > 935622bef38cc3d399e8b5b1db84fa21c79c78e1 > > src/test/java/org/apache/aurora/scheduler/configuration/ConfigurationManagerTest.java > 317506eb01457f8eee013fed40f16895369c660f > > src/test/java/org/apache/aurora/scheduler/cron/quartz/AuroraCronJobTest.java > 5c64ff2994e200b3453603ac5470e8e152cebc55 > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronIT.java > 3ce78e355368acb539cd374638be665535bbfd4a > > src/test/java/org/apache/aurora/scheduler/cron/quartz/CronJobManagerImplTest.java > 81440f5689f9538a4c7a9e6700bf03ca89c4ba85 > src/test/java/org/apache/aurora/scheduler/cron/quartz/QuartzTestUtil.java > ef9aae11a9fcecf099241817528dbf2213515802 > > src/test/java/org/apache/aurora/scheduler/events/NotifyingSchedulingFilterTest.java > b9f9f529d2ea765e89dd751057228631359a66e1 > > src/test/java/org/apache/aurora/scheduler/filter/AttributeAggregateTest.java > 209f9298a1d55207b9b41159f2ab366f92c1eb70 > > src/test/java/org/apache/aurora/scheduler/filter/SchedulingFilterImplTest.java > 17101f101f2ec1e9be75622ad31c760f46edd8c8 > src/test/java/org/apache/aurora/scheduler/http/AbstractJettyTest.java > 19c8a1fe06a333324022da11f74d7c96b2942587 > src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java > 367826646bb4dd300454cac382a9f25b6f2d4218 > src/test/java/org/apache/aurora/scheduler/http/LocksTest.java > 94c3c294737e49f04fe5467d9de6a951d1f78c46 > src/test/java/org/apache/aurora/scheduler/http/MnameTest.java > c25264fef2f3e9a627a084685f5e019be14dbf71 > src/test/java/org/apache/aurora/scheduler/http/UtilTest.java PRE-CREATION > src/test/java/org/apache/aurora/scheduler/http/api/ApiBetaTest.java > f14d405ea3975d1045b62a77238b420dbb6cf3a8 > src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java > 31f5cb3bed48eef60c3b2becb2ed285e93f2bd5a > > src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java > dfe94d3fadc3f5e3322dd5a3a367ad6ef22c2a99 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthenticatingThriftInterceptorTest.java > 6642fa921ac705b0f3e7fa4a1af9ebe4ecf1ec18 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingInterceptorTest.java > 1d6af3df8b90c0359255e7baa0c96d88b93a0562 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java > b5b405bdff189120a0e8e2beb1159571321d5b96 > > src/test/java/org/apache/aurora/scheduler/http/api/security/ThriftFieldGetterTest.java > b0a8d750ffcbf072e373ed996feba63f5276feb3 > src/test/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImplTest.java > 242530a8fdab8707e4ff79efae87da7bc840d247 > > src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java > cc2a4155008672056410086b05b6cc875485f669 > src/test/java/org/apache/aurora/scheduler/metadata/NearestFitTest.java > d9b3cc672f42c50b2a2a142733d26c0725bbc864 > src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java > 76da6d80d91221336e50d596cc2f49e890451fd1 > > src/test/java/org/apache/aurora/scheduler/preemptor/ClusterStateImplTest.java > 881bb20feaa83797831828a3cdd7a2f507621387 > > src/test/java/org/apache/aurora/scheduler/preemptor/PendingTaskProcessorTest.java > d11ae5883f2a00dca4c4b36f0ab58ea95c7ecb2e > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilterTest.java > ef20641b056a38d3f816acf476dd3e6f12f22ce0 > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimTest.java > 09380f95a7d9405f770513db35d2a45d23d89b61 > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorImplTest.java > 98048fabc00f233925b6cca015c2525980556e2b > > src/test/java/org/apache/aurora/scheduler/preemptor/PreemptorModuleTest.java > 2c3e5f32c774be07a5fa28c8bcf3b9a5d88059a1 > > src/test/java/org/apache/aurora/scheduler/pruning/JobUpdateHistoryPrunerTest.java > 20f790ef4d04cd8aaa7cdab4442040a31fa72838 > > src/test/java/org/apache/aurora/scheduler/pruning/TaskHistoryPrunerTest.java > ffeee1bebdb403be9179a8160e4d9a01aaf1f56b > src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java > d989900d736ad10df07fb419d147eb6646fd5d4a > src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java > aedeab3fb89ca88df5f37e14bbcf0a109dfecbe7 > src/test/java/org/apache/aurora/scheduler/reconciliation/KillRetryTest.java > a561d0909cef27b24334165f0d40cfd734b2c9a6 > > src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java > 5b4b3ac9781c9b572bbc9507c238dfa3b0177b45 > > src/test/java/org/apache/aurora/scheduler/reconciliation/TaskTimeoutTest.java > 1006ddb6caea015c2d4e014bd044f2933541c84f > > src/test/java/org/apache/aurora/scheduler/scheduling/RescheduleCalculatorImplTest.java > 2d34729e8f371703ba250b8e82d82c8a2504fcac > src/test/java/org/apache/aurora/scheduler/scheduling/TaskGroupsTest.java > 95cf25eda0a5bfc0cc4c46d1439ebe9d5359ce79 > > src/test/java/org/apache/aurora/scheduler/scheduling/TaskSchedulerImplTest.java > 4c447b27052d4c253909fc74269d71efcdf89d29 > src/test/java/org/apache/aurora/scheduler/scheduling/TaskThrottlerTest.java > 7d104aa2ea4a4d99be4711f666d18beca238284e > src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java > 953b65f28a585375e36e305dea6f9f94f99abc93 > src/test/java/org/apache/aurora/scheduler/sla/SlaAlgorithmTest.java > 90ea3a169dadc72e7d7493544ab865ec59d4d425 > src/test/java/org/apache/aurora/scheduler/sla/SlaTestUtil.java > 78f440f7546de9ed6842cb51db02b3bddc9a74ff > src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java > a146e4005943a58e0d2df0773fc10e6489c12daa > > src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java > 94f5ca565476f62d72879837a0e7dafabcf30432 > src/test/java/org/apache/aurora/scheduler/state/StateManagerImplTest.java > 498da78169be42fd5edeb9963d8262af02895f0e > src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java > b00add0b2fd4277e196505fffba4440e2e94207e > src/test/java/org/apache/aurora/scheduler/state/TaskStateMachineTest.java > c5193238db5cb65373f7cb69e6b38b2e3b051dae > src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java > f6bbbb81c15e917a54f084cf62787d85fc14e547 > src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java > 845de41c2dc332d3f1a25f37f3c7d25c3bf1014d > src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java > 6af1fffceb5cdc7406a67d608e4a01ebdf71a2d0 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractCronJobStoreTest.java > 22a6b43c97f6b0d2294d9cda218cf2889838f1c9 > > src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java > dee34e29465d58adbc805cbb9c400e0328012ab8 > src/test/java/org/apache/aurora/scheduler/storage/backup/RecoveryTest.java > 172dd206d09f131807cb33fe841ca6ebc8198a14 > > src/test/java/org/apache/aurora/scheduler/storage/backup/StorageBackupTest.java > 7b3f18563594d62265adeffac8fdd83c562ccb24 > > src/test/java/org/apache/aurora/scheduler/storage/db/DbAttributeStoreTest.java > f47f4a8a492fb43bacd909dc520256ed028531dd > > src/test/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStoreTest.java > d035513435b9b07027747bb13b7810061f489474 > src/test/java/org/apache/aurora/scheduler/storage/db/DbLockStoreTest.java > 8ed58e01eea09ab9f1aa4d269a5e59ce9c9c2191 > src/test/java/org/apache/aurora/scheduler/storage/db/DbQuotaStoreTest.java > e0ec99583044b557b67312f442efdd6bf43e2c1a > > src/test/java/org/apache/aurora/scheduler/storage/db/RowGarbageCollectorTest.java > 58b4c9312e5c7d12144af56b3896161c039d5288 > > src/test/java/org/apache/aurora/scheduler/storage/entities/IHostAttributesTest.java > 4dcc3e5656b9f06a71441b438518bf89a3269067 > src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java > 0443bb3ad7350bc442463fd1d4c0b51ddb38301e > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > 7382eca281eeab17d407ed140f16d6a633d8ad72 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicatorImplTest.java > 5546cf626082cdc06b9400f3e4aad0db6d0f68d6 > > src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplTest.java > 806f50d57e44261e3a1988a3c9bb742442badde8 > > src/test/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorageTest.java > 13726cc11ab09cd4995233d9d31811b97b065275 > > src/test/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 5a2524dd68638018b0b57ff4a48c93526a5fc9df > > src/test/java/org/apache/aurora/scheduler/storage/mem/StorageTransactionTest.java > ba5969a9128f5aff93c06ddc258f32a215d71f46 > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageEntityUtil.java > 5af2813e67cb6333ac45096949ba9b2fce92155d > > src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > 21d26b3930ea965487b2dec48a48a98677ba022b > src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java > 72d21829239f771a9df192b417147d871521d24f > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > 0428c779eabd16fe88ee1e41150cc76e3731fe8d > > src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java > b9ce2ddba051ab2baed59108d70537d84a031934 > src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java > 860d9607505c0a28c1d0050faa04143b0ab8a097 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdminTest.java > e4bc76bd2331387dd5bcbbcb8698227c098dffb4 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/AuroraSchedulerManagerAuthorizingParamTest.java > PRE-CREATION > > src/test/java/org/apache/aurora/scheduler/thrift/aop/LoggingInterceptorTest.java > 8dff558e5e8b4a181b207a8fb84385deb670189d > > src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java > 0547b1acf0c1fc09898fe05777f45cbaa169eea7 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/ServerInfoInterceptorTest.java > b975277c669113f1cb8c19c4725b7b25aca541d7 > > src/test/java/org/apache/aurora/scheduler/thrift/aop/ThriftStatsExporterInterceptorTest.java > 9c40ec51c28c8c57365dc21c3cd7391a3894784c > src/test/java/org/apache/aurora/scheduler/updater/AddTaskTest.java > 56c94b5caf414861212f673a27b84d46c07332e6 > src/test/java/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java > c78c7fbd7d600586136863c99ce3d7387895efee > src/test/java/org/apache/aurora/scheduler/updater/JobDiffTest.java > 67fe14b2fa90f9577b8ccab1e2c7b9e8a82e74b6 > > src/test/java/org/apache/aurora/scheduler/updater/JobUpdateEventSubscriberTest.java > 36f2c657c05a87e78a11a1b0be5779dfd6511ee5 > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > 2024b2c50d5d1e44f3f95b915c8bcd58e39379cb > src/test/java/org/apache/aurora/scheduler/updater/KillTaskTest.java > e5935f65924e7d9a2491cac8f4c1f575ec657776 > > src/test/java/org/apache/aurora/scheduler/updater/UpdateFactoryImplTest.java > c31e082ef3dd3a40d9cb7926aa277e86399a06bd > > Diff: https://reviews.apache.org/r/42756/diff/ > > > Testing > ------- > > Locally green: > ``` > ./build-support/jenkins/build.sh > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >