-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42845/#review116545
-----------------------------------------------------------



Master (9faec2f) is green with this patch.
  ./build-support/jenkins/build.sh

However, it appears that it might lack test coverage.

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 27, 2016, 5:37 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42845/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 5:37 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> On a test cluster with DbTaskStore enabled there are several lines in the log 
> that look like:
> ````
> 2016-01-26 13:07:14 jdbc[15]: exception
> ````
> There is no other information with these lines. This is a result of setting 
> `TRACE_LEVEL_SYSTEM_OUT` to `1` for H2. This will print out the error message 
> but not the associated throwable: 
> https://github.com/h2database/h2database/blob/a932268843ac84c7a665e427167ff2eb291d6b8e/h2/src/main/org/h2/message/TraceSystem.java#L228
> 
> The SLF4J implementation of tracing in H2 does not suffer from this 
> restriction.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> 36c462ac86cc605bd86bfc31c2f962a315099a02 
>   src/main/resources/logback.xml faf0dbc94dea536a944be18810a7f330d4c94dee 
> 
> Diff: https://reviews.apache.org/r/42845/diff/
> 
> 
> Testing
> -------
> 
> Set the level to debug initially and observed extra output in Vagrant.
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to