-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42816/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 1:15 p.m.)
Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Dmitriy Shirchenko,
and Bill Farner.
Changes
-------
Kill more unused cruft from health check config validation removal.
src/main/python/apache/aurora/client/config.py | 9 ---------
1 file changed, 9 deletions(-)
Bugs: AURORA-1552 and AURORA-1563
https://issues.apache.org/jira/browse/AURORA-1552
https://issues.apache.org/jira/browse/AURORA-1563
Repository: aurora
Description
-------
Remove `endpoint`, `expected_response` and `expected_response_code`
which were all deprecated in Aurora 0.11.0 in favor of the same-named
fields in `HttpHealthChecker`.
This also removes health check validation in the client in favor of
leveraging the pystachio schema. The one difference this allows for is
an empty string for the `ShellHealthChecker.shell_command`. Since an
empty string is a valid shell command (equivalent to `true`), this
simplification seems justified.
NEWS | 3 ++
docs/configuration-reference.md | 3 --
src/main/python/apache/aurora/client/config.py | 31
------------------
src/main/python/apache/aurora/config/schema/base.py | 5 +--
src/main/python/apache/aurora/executor/common/health_checker.py | 17 +++-------
src/test/python/apache/aurora/client/test_config.py | 88
--------------------------------------------------
6 files changed, 9 insertions(+), 138 deletions(-)
Diffs (updated)
-----
NEWS 0e9f3b30dca5311530d7be41a5295994377dac3d
docs/configuration-reference.md c04f3b7c927ff44c26b38ce38a65041c24a68e81
src/main/python/apache/aurora/client/config.py
a4fa48533b8266dd8e87eb830677f200e7e3cbb2
src/main/python/apache/aurora/config/schema/base.py
0e4dfc220bbecc5f679b067833dffc253c912d85
src/main/python/apache/aurora/executor/common/health_checker.py
01194aa47d31ac058b89bce8662cec58856dc5f4
src/test/python/apache/aurora/client/test_config.py
de0973d7901301433c3d9dca7bac8555a74604c9
Diff: https://reviews.apache.org/r/42816/diff/
Testing
-------
Locally green:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```
Thanks,
John Sirois
