-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42879/#review116679
-----------------------------------------------------------


Ship it!




Ship It!

- Maxim Khutornenko


On Jan. 27, 2016, 11:34 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42879/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 11:34 p.m.)
> 
> 
> Review request for Aurora, Joe Smith and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1282
>     https://issues.apache.org/jira/browse/AURORA-1282
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Allow dots and hyphens in metric names. This will make sure we won't warn 
> about invalid stat names for valid job identifiers [1].
> 
> [1] 
> https://github.com/apache/aurora/blob/0813e3a4445997b6a25a75f0401bbeb7aa87363b/api/src/main/thrift/org/apache/aurora/gen/api.thrift#L433
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 613bdb9738ebb069722e9d9675a0590cf36ffb15 
>   commons/src/test/java/org/apache/aurora/common/stats/StatsTest.java 
> 5368ba5a0c9a98b4bf8142c7ab59c0864e201706 
> 
> Diff: https://reviews.apache.org/r/42879/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to