> On Jan. 28, 2016, 5:56 a.m., Aurora ReviewBot wrote:
> > Master (89fad5a) is green with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > However, it appears that it might lack test coverage.
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"
> 
> Maxim Khutornenko wrote:
>     Add a NEWS entry to highlight this change?
> 
> Bill Farner wrote:
>     I don't really think this is newsworthy.  It's likley a no-op for 
> everyone, and shrug-worthy at best for even the most interested of people.  
> I'd expect anyone interested in this level of detail would be best served 
> following the commit log.

To an operator (or anyone how ever debugged task-related issues), it could be 
quite puzzling to see different task ID formats in the scheduler/mesos logs. I 
think it's better to throw a line into the release news and let readers decide 
what's newsworthy than waste someone's time crawling trough the code/gitlog 
trying to understand the nature of that discrepancy.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42896/#review116720
-----------------------------------------------------------


On Jan. 28, 2016, 4:53 a.m., Bill Farner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42896/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2016, 4:53 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove timestamp from task IDs.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/TaskIdGenerator.java 
> 35675acfad8f98e833e0dba277ff65943a21db91 
> 
> Diff: https://reviews.apache.org/r/42896/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Bill Farner
> 
>

Reply via email to