-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42953/#review116935
-----------------------------------------------------------



Master (0eb753d) is red with this patch.
  ./build-support/jenkins/build.sh

                           job_dict = env['jobs'][0].get()
                           job_dict['unknown_attribute'] = 'foo bar baz'
                           job_json_string = json.dumps(job_dict)
                           # If this fails, will raise an 
InvalidConfigError or other exception and fail the test.
                     >     
AuroraConfigLoader.loads_json(job_json_string)
                     
                     src/test/python/apache/aurora/config/test_loader.py:63: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
.pants.d/python-setup/chroots/e41daa35f608579a1e7bae55f6811e6403a710f9/apache/aurora/config/loader.py:79:
 in loads_json
                         'jobs': [base_schema.Job(x) for x in 
parsed.get('jobs')]
                     
.pants.d/python-setup/chroots/e41daa35f608579a1e7bae55f6811e6403a710f9/.deps/pystachio-0.8.0-py2.py3-none-any.whl/pystachio/composite.py:160:
 in __init__
                         self._update_schema_data(**arg)
                     
.pants.d/python-setup/chroots/e41daa35f608579a1e7bae55f6811e6403a710f9/.deps/pystachio-0.8.0-py2.py3-none-any.whl/pystachio/composite.py:180:
 in _update_schema_data
                         self._schema_data[attr] = 
self._process_schema_attribute(attr, value)
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     self = <[AttributeError("MesosJob has no attribute 
_scopes") raised in repr()] SafeRepr object at 0x7fe59f4c0878>
                     attr = 'unknown_attribute', value = 'foo bar baz'
                     
                         def _process_schema_attribute(self, attr, 
value):
                           if attr not in self.TYPEMAP:
                     >       raise AttributeError('Unknown schema attribute 
%s' % attr)
                     E       AttributeError: Unknown schema attribute 
unknown_attribute
                     
                     
.pants.d/python-setup/chroots/e41daa35f608579a1e7bae55f6811e6403a710f9/.deps/pystachio-0.8.0-py2.py3-none-any.whl/pystachio/composite.py:169:
 AttributeError
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/src.test.python.apache.aurora.config.config.xml
 
                     ====== 1 failed, 27 passed in 3.29 seconds 
=======
                     
                     src.test.python.apache.aurora.client.client                
                     .....   SUCCESS
                     src.test.python.apache.aurora.client.hooks.hooks           
                     .....   SUCCESS
                     src.test.python.apache.aurora.config.config                
                     .....   FAILURE
                     src.test.python.apache.aurora.tools.tools                  
                     .....   SUCCESS
                     src.test.python.apache.thermos.core.core                   
                     .....   SUCCESS
                     src.test.python.apache.thermos.monitoring.monitoring       
                     .....   SUCCESS
                     src.test.python.apache.thermos.observer.http.http          
                     .....   SUCCESS
FAILURE


09:13:56 04:12   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On Jan. 29, 2016, 8:44 a.m., Benjamin Staffin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42953/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2016, 8:44 a.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Bugs: AURORA-1577
>     https://issues.apache.org/jira/browse/AURORA-1577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Still handles the old --read-json behavior of expecting a single job,
> but adds the ability to read files with a {"jobs": [job1, job2, ...]}
> schema like the pystachio format.
> 
> Also adds --read-json to the `aurora config load` command, as it is
> now useful there.
> 
> Fixes: AURORA-1577
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/config.py 
> 73b556266183bf17463881b87cda107d07d79d71 
>   src/main/python/apache/aurora/config/__init__.py 
> 665e2cd08d4146e652b13bb82e04680315a1eebe 
>   src/main/python/apache/aurora/config/loader.py 
> a967b9dca353f5a70c89abee5d45220a9593c01a 
>   src/test/python/apache/aurora/config/test_loader.py 
> 9789255cb0280ef0d1a83cd8c1cf8fa3581553b5 
> 
> Diff: https://reviews.apache.org/r/42953/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benjamin Staffin
> 
>

Reply via email to